Skip to content

Remove remaining author-name + parenthetical-cite duplications#22

Merged
MaxGhenis merged 1 commit into
mainfrom
paper-more-cite-fixes
May 16, 2026
Merged

Remove remaining author-name + parenthetical-cite duplications#22
MaxGhenis merged 1 commit into
mainfrom
paper-more-cite-fixes

Conversation

@MaxGhenis
Copy link
Copy Markdown
Contributor

Summary

Found two more instances of the same Shanahan-style duplication on line 989 (Reference-output credibility section). Both used parenthetical citations where the cited author institution was also named in the prose right before the cite, so the rendered text echoed the name.

  • "PolicyEngine reports matching ... PolicyEngine's integration tests (PolicyEngine 2024; Feenberg and Coutts 1993)." → "PolicyEngine (2024) reports matching the NBER TAXSIM-35 model (Feenberg and Coutts 1993) to the cent ... with state-specific differences documented in the integration tests."
  • "...the Federal Reserve Bank of Atlanta for future validation work against the Atlanta Fed's Policy Rules Database (Ghenis and Makarchuk 2025; Federal Reserve Bank of Atlanta 2026)." → "...signed a memorandum of understanding (Ghenis and Makarchuk 2025) with the Federal Reserve Bank of Atlanta for future validation work against its Policy Rules Database (2026)."

Same fix shape as #21 (Shanahan): use `@key` author-in-text or `[-@key]` year-only suppression instead of plain `[@key]` when the institution is already in the prose.

Test plan

  • Re-rendered HTML+PDF, inspected rendered prose — no more author-name echoes in parenthetical cites.
  • Scanned every parenthetical citation in the rendered HTML against the surname-in-prose check used for the Shanahan fix; zero remaining hits.
  • Snapshot manifest refreshed for the new artifact hashes; `tests/test_snapshot_artifacts.py` passes locally.

Two cases on line 989 read awkwardly after rendering:

- "PolicyEngine reports matching … PolicyEngine's integration tests
  (PolicyEngine 2024; …)." → "PolicyEngine (2024) reports matching the
  NBER TAXSIM-35 model (Feenberg and Coutts 1993) to the cent … with
  state-specific differences documented in the integration tests."

- "…the Federal Reserve Bank of Atlanta for future validation work
  against the Atlanta Fed's Policy Rules Database (Ghenis and Makarchuk
  2025; Federal Reserve Bank of Atlanta 2026)." → "…signed a memorandum
  of understanding (Ghenis and Makarchuk 2025) with the Federal Reserve
  Bank of Atlanta for future validation work against its Policy Rules
  Database (2026)."

Both use the same author-in-text / year-suppressed citation form as
the Shanahan fix so the institution name appears once instead of being
echoed in the rendered parenthetical. Snapshot manifest refreshed for
the re-rendered HTML and PDF.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
policybench-site Ready Ready Preview, Comment May 16, 2026 0:54am

Request Review

@MaxGhenis MaxGhenis merged commit 28b0caf into main May 16, 2026
4 checks passed
@MaxGhenis MaxGhenis deleted the paper-more-cite-fixes branch May 16, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant