Roll the default context builder into contextbuilder#687
Merged
Conversation
…tilized level of indirection
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the separate DefaultContextBuilder implementation and folds its behavior into ContextBuilder, with the intent of reducing indirection and ensuring a builder can’t mutate the configuration after a Context has been created (by snapshotting builder state into the produced ContextConfig).
Changes:
- Deleted
DefaultContextBuilderand moved its implementation logic intoContextBuilder. - Converted
ContextBuilderfrom an interface into a concrete class with fluent configuration methods andbuild(). - Updated
toConfig()to produce an immutable snapshot (copy) of builder state rather than a live view tied to the builder instance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pi4j-core/src/main/java/com/pi4j/context/impl/DefaultContextBuilder.java | Removed the dedicated default builder implementation to eliminate an extra indirection layer. |
| pi4j-core/src/main/java/com/pi4j/context/ContextBuilder.java | Inlined the default builder implementation and updated toConfig() to snapshot state for immutability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+23
to
+24
| public class ContextBuilder implements Builder<Context> { | ||
| protected Logger logger = LoggerFactory.getLogger(ContextBuilder.class); |
|
FDelporte
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing an unutilized level of indirection
Also stop builder changes from affecting a constructed context (builder, you had one job... :)
Part of #671