Skip to content

Don't take the length of None#91

Closed
j3pic wants to merge 9 commits into
ParallelSSH:masterfrom
pictretail:fix-type-bug
Closed

Don't take the length of None#91
j3pic wants to merge 9 commits into
ParallelSSH:masterfrom
pictretail:fix-type-bug

Conversation

@j3pic

@j3pic j3pic commented Dec 4, 2019

Copy link
Copy Markdown

Should fix #86

@j3pic

j3pic commented Dec 5, 2019

Copy link
Copy Markdown
Author

I just realized you have those .c files committed to the repo instead of generating them in the build. I have no idea how to compile .pyx to C.

@j3pic

j3pic commented Dec 5, 2019

Copy link
Copy Markdown
Author

I have confirmed that it's possible to call userauth_publickey_frommemory with None for the host key.

@kdart-brt

Copy link
Copy Markdown

The maintainer seems to have disappeared. Should we fork it?

@pkittenis

Copy link
Copy Markdown
Member

Thanks for the PR. This needs a short test to confirm functionality.

@pkittenis

Copy link
Copy Markdown
Member

Done by #104

@pkittenis pkittenis closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ssh2.session.Session.userauth_publickey_frommemory() - TypeError: object of type 'NoneType' has no len()

3 participants