[Feature] consolidate cache, worker_process, and paddle logs into unified files#7432
[Feature] consolidate cache, worker_process, and paddle logs into unified files#7432xyxinyang wants to merge 1 commit intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7432 +/- ##
==========================================
Coverage ? 74.27%
==========================================
Files ? 398
Lines ? 55008
Branches ? 8622
==========================================
Hits ? 40858
Misses ? 11406
Partials ? 2744
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 AI Code Review |
2026-04-17 11:51 CST
📋 Review 摘要
PR 概述:将 cache、worker_process 和 paddle 分布式日志整合到统一文件中,减少日志碎片化,并在主日志目录创建 workerlog 软链接方便查阅。
变更范围:cache_manager/、engine/、worker/、model_executor/graph_optimization/、logger/、utils.py
影响面 Tag:Engine KVCache
📝 PR 规范检查
PR 描述的 Motivation、Modifications、Usage or Command、Accuracy Tests 各节均仅填写了 "1",缺乏对变更动机和具体修改内容的说明。建议补充描述,方便后续追溯。
描述模板(可直接复制):
## Motivation
Consolidate scattered log files (gpu_worker.log, model_runner_base.log, cudagraph_piecewise_backend.log, cache_storage.log, etc.) into unified files (worker_process.log, cache_manager.log) for easier debugging. Also move paddle distributed launch logs into a paddle/ subdirectory with symlinks in the main log dir.
## Modifications
1. Renamed log files: gpu_worker.log/model_runner_base.log/cudagraph_piecewise_backend.log → worker_process.log; cache_transfer.log/cache_storage.log → cache_manager.log
2. Moved paddle distributed launch logs to log/paddle/ subdirectory, with symlinks created in the main log directory
3. Changed register_manager_logger to use "main" channel instead of a separate file
4. Downgraded verbose info logs in engine_cache_queue.py to debug level
5. Added ensure_workerlog_alias utility and corresponding unit tests
问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🟡 建议 | prefix_cache_manager.py:348 |
错误提示日志文件名与实际文件名不匹配 |
| 🟡 建议 | utils.py:191 |
except OSError: pass 过于宽泛,建议至少记录警告日志 |
总体评价
日志整合的方向合理,将分散的日志统一到 worker_process.log 和 cache_manager.log 能显著改善调试体验。代码改动较为直接,测试覆盖充分。建议补充 PR 描述并修复错误提示中的文件名不一致问题。
Motivation
1
Modifications
1
Usage or Command
1
Accuracy Tests
1
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.