Skip to content

APIs to get unsynced beneficiaries and count of unsynced beneficiaries - For CHO mobile application#45

Merged
ravishanigarapu merged 7 commits intoPSMRI:developfrom
beehyv:develop
Jan 18, 2024
Merged

APIs to get unsynced beneficiaries and count of unsynced beneficiaries - For CHO mobile application#45
ravishanigarapu merged 7 commits intoPSMRI:developfrom
beehyv:develop

Conversation

@shreypatidar-beehyv
Copy link
Copy Markdown

@shreypatidar-beehyv shreypatidar-beehyv commented Dec 19, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix
  • New feature
  • Enhancement
  • Refactoring
  • Documentation
  • Other ( please specify )

How Has This Been Tested?

-This service has been deployed and tested on Beehyv staging server.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@drtechie
Copy link
Copy Markdown
Member

@devikasuresh20, @ravishanigarapu can you please review the business logic.
Code wise LGTM.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you changed searchByDistrictId endpoint to searchByVillageIdAndLastModifiedDate
because of searchByDistrictId already we are using in WHC API.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an API that returns the list of beneficiaries based on a list of village IDs and the last sync date time. It is used to sync beneficiaries for the CHO Android mobile application. Since this and the upstream APIs (In HWC-API) using this endpoint were created by our team and required some changes i.e. why did the modifications as well as the name change .
As for the HWC-API, this endpoint has also been updated there in the properties files.

Copy link
Copy Markdown
Contributor

@ravishanigarapu ravishanigarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@ravishanigarapu ravishanigarapu merged commit 6d206fb into PSMRI:develop Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants