changing commonapi-v1.0 to 3.0.0#185
changing commonapi-v1.0 to 3.0.0#185srinuatpiramal wants to merge 8 commits intoPSMRI:developfrom srinuatpiramal:develop
Conversation
changing <finalName>commonapi-v1.0</finalName> to commonapi-v3.0.0
WalkthroughThis update modifies several configuration files and the Maven project descriptor. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PropertiesFile
participant Application
User->>PropertiesFile: Sets grievanceDataSyncDuration (via env or placeholder)
Application->>PropertiesFile: Reads grievanceDataSyncDuration
Application->>Application: Uses configured duration in sync logic
User->>PropertiesFile: Sets IDENTITY_BASE_URL properties
Application->>PropertiesFile: Reads identity API URLs
Application->>Application: Uses updated URLs for API calls
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (6)
src/main/environment/common_example.properties (1)
127-127: Fix typo in placeholder text for grievanceDataSyncDurationThe placeholder string spells “Grievience” incorrectly; update it to “Grievance” to match the property key and improve readability.
Proposed diff:
- grievanceDataSyncDuration = <Enter Grievience Data Sync Duration> + grievanceDataSyncDuration = <Enter Grievance Data Sync Duration>src/main/environment/common_uat.properties (1)
156-156: Fix typo in placeholder text and standardize placeholder format.
The placeholder<Enter Grievience Data Sync Duration>contains a typo (“Grievience” → “Grievance”) and deviates from the pattern used in other environments. Please correct the spelling to “Grievance” and consider using a consistent environment‐variable placeholder (for example,@env.GRIEVANCE_DATA_SYNC_DURATION@) to align with CI and other UAT configurations.pom.xml (1)
9-9: Consider bumping the POM<version>
The<version>element remains at1.0.1, which diverges from the new artifact name (v3.0.0). For consistency and to leverage Maven's versioning, consider updating:-<version>1.0.1</version> +<version>3.0.0</version>src/main/environment/common_dev.properties (1)
183-183: Typo in placeholder and formatting
The placeholder<Enter Grievience Data Sync Duration>contains a spelling mistake and extra spaces around=. Please correct and align with the key:-grievanceDataSyncDuration = <Enter Grievience Data Sync Duration> +grievanceDataSyncDuration=<Enter Grievance Data Sync Duration>src/main/environment/common_ci.properties (1)
154-154: Standardize placeholder syntax and spacing
Ensure consistency in formatting and confirm that the Maven filtering will replace this placeholder:-grievanceDataSyncDuration = @env.GRIEVANCE_DATA_SYNC_DURATION@ +grievanceDataSyncDuration=@env.GRIEVANCE_DATA_SYNC_DURATION@src/main/environment/common_test.properties (1)
184-184: Correct typo in placeholder and standardize placeholder formatThe placeholder string
<Enter Grievience Data Sync Duration>contains a spelling error (“Grievience”). It should read<Enter Grievance Data Sync Duration>. Additionally, consider adopting a consistent placeholder syntax (e.g.,${GRIEVANCE_DATA_SYNC_DURATION}or@env.GRIEVANCE_DATA_SYNC_DURATION@) across all environment files to reduce the risk of misconfiguration.Apply this diff:
- grievanceDataSyncDuration = <Enter Grievience Data Sync Duration> + grievanceDataSyncDuration = <Enter Grievance Data Sync Duration>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
pom.xml(1 hunks)src/main/environment/common_ci.properties(1 hunks)src/main/environment/common_dev.properties(1 hunks)src/main/environment/common_example.properties(1 hunks)src/main/environment/common_test.properties(1 hunks)src/main/environment/common_uat.properties(1 hunks)src/main/resources/application.properties(1 hunks)
| <org.mapstruct.version>1.2.0.Final</org.mapstruct.version> | ||
| <org.projectlombok.version>1.16.18</org.projectlombok.version> | ||
| <final-name>commonapi-v1.0</final-name> | ||
| <final-name>commonapi-v3.0.0</final-name> |
There was a problem hiding this comment.
Inconsistent artifact final-name in build section
The <final-name> property under <properties> was updated to commonapi-v3.0.0, but the <build> section still uses:
<finalName>commonapi-v1.0</finalName>This mismatch will package the WAR under the old name.
Please align the <build> finalName:
<build>
- <finalName>commonapi-v1.0</finalName>
+ <finalName>commonapi-v3.0.0</finalName>
...| identity-api-url-advancesearch =IDENTITY_BASE_URL/id/advanceSearch | ||
| identity-api-url-getByBenRegIdList =IDENTITY_BASE_URL/id/getByBenRegIdList | ||
| identity-api-url-getByPartialBenRegIdList =IDENTITY_BASE_URL/id/getByPartialBenRegIdList | ||
| identity-api-url-getByPhoneNum =IDENTITY_BASE_URL/id/getByPhoneNum?phoneNum= | ||
| identity-api-url-getByBenId =IDENTITY_BASE_URL/id/getByBenId?benId= | ||
| identity-api-url-getByBenRegId =IDENTITY_BASE_URL/id/getByBenRegId?benRegId= | ||
| identity-api-url-benCreate =IDENTITY_BASE_URL/id/create | ||
| identity-api-url-benEdit =IDENTITY_BASE_URL/id/edit | ||
| identity-api-url-benEditEducationCommunity=IDENTITY_BASE_URL/id/editEducationOrCommunity | ||
|
|
||
| identity-api-url-getByFamilyId=IDENTITY_BASE_URL/id/searchByFamilyId?familyId= | ||
| identity-api-url-getByGovIdentity=IDENTITY_BASE_URL/id/searchByGovIdentity?identity= | ||
|
|
||
| ## ABHA id based search URL | ||
| identity-api-url-getByHealthID=IDENTITY_API_URL/id/getByAbhaAddress?healthID= | ||
| identity-api-url-getByHealthIDNo=IDENTITY_API_URL/id/getByAbhaIdNo?healthIDNo= | ||
| identity-api-url-getByHealthID=IDENTITY_BASE_URL/id/getByAbhaAddress?healthID= | ||
| identity-api-url-getByHealthIDNo=IDENTITY_BASE_URL/id/getByAbhaIdNo?healthIDNo= | ||
|
|
There was a problem hiding this comment.
Broken placeholder usage for identity URLs
The new identity URL entries reference IDENTITY_BASE_URL literally, but there is no property defined for it, and they lack ${...} syntax. These values will not resolve at runtime. You have two options:
- Define the base URL property:
And reference it:
IDENTITY_BASE_URL=https://your.identity.endpointidentity-api-url-advancesearch=${IDENTITY_BASE_URL}/id/advanceSearch - Hardcode the full URL for each endpoint.
Please update accordingly to avoid unresolved placeholders.
1 participant
📋 Description
JIRA ID:
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit