RDOIAT-522 - add changeFocusedOption method#30
Merged
OS-ruineves merged 6 commits intomainfrom Nov 18, 2022
Merged
Conversation
os-lmo
reviewed
Nov 17, 2022
|
|
||
| this.setState({ | ||
| focusedOption: optionToFocus, | ||
| }) |
There was a problem hiding this comment.
In the other focusOption function, we are also:
- Changing the the state of
focusedValueto null - Setting
this.scrollToFocusedOptionOnUpdate = true;
https://github.com/OutSystems/react-select/blob/main/src/Select.js#L594
Aren't they needed here also?
Author
There was a problem hiding this comment.
- focusedValue is used on multi select dropdowns, I had removed it while debugging, value operations change focusedOption to null, and option operations change focusedValue to null, so I will be adding it back again
- yes, this should improve the experience on dropdowns with a bigger number of options
There was a problem hiding this comment.
Also, what does the announceAriaLiveContext that is being called in other operations? Seems to update some kind of instructions. What are we losing not calling that here?
Author
There was a problem hiding this comment.
announceAriaLiveContext and announceAriaLiveSelection are disabled in the web-components code, with the allowScreenReaders prop
|
Can you check if our pipeline is executing the automatic tests? In that case, can you create a test here - https://github.com/OutSystems/react-select/blob/main/src/__tests__/Select.test.js |
os-lmo
approved these changes
Nov 17, 2022
osplm
reviewed
Nov 18, 2022
src/Select.js
Outdated
| return; | ||
| } | ||
|
|
||
| let optionToFocus = options.find(e => e.label == opt); |
osplm
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added changeFocusedOption that allows the dropdown on SS to focus perfect matchs when searching