This repository was archived by the owner on Dec 3, 2019. It is now read-only.
add new routes for frontend authentication and user flow#473
Open
apex-omontgomery wants to merge 9 commits intomasterfrom
Open
add new routes for frontend authentication and user flow#473apex-omontgomery wants to merge 9 commits intomasterfrom
apex-omontgomery wants to merge 9 commits intomasterfrom
Conversation
added 3 commits
April 18, 2019 20:48
kylemh
reviewed
Apr 21, 2019
| if user.save | ||
| user.welcome_user | ||
| user.invite_to_slack | ||
| user.add_to_send_grid |
Member
There was a problem hiding this comment.
these should probably occur after sign_in right? Unsure why user.welcome_user was listed before UserMailer.welcome(user).deliver unless user.invalid?
| end | ||
| end | ||
|
|
||
| def me |
Member
There was a problem hiding this comment.
what's happening in this method?
| def invite(extra_message:, email:, channels: []) | ||
| Rails.logger.info "Inviting user with email '#{email}'" | ||
| # unsure if some string expansion is causing an error here | ||
| Rails.logger.info 'Inviting slack user user' |
Member
There was a problem hiding this comment.
you can prolly delete this line and comment above
Member
|
Would still love to see API documentation updated FWIW - u had that in this PR |
Member
|
I bring you back from the dead - i want all of u |
kylemh
reviewed
Apr 22, 2019
| + zip (string, required) - Zipcode of the User in the form of a string | ||
| + first_name (string, required) - First Name of the user in the form of an string | ||
| + last_name (string, required) - Last Name of the user in the form of an string | ||
| + mentor (string, optional) - in the form of a string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue Resolved
Fixes #471