Feature:add new formatters for Tickets#494
Conversation
andrestejerina97
force-pushed
the
feature/add-ticket-formatters
branch
from
d325475 to
4b7ad9c
Compare
There was a problem hiding this comment.
@andrestejerina97 please review comments. Thanks
app/Audit/ConcreteFormatters/PrePaidSummitRegistrationDiscountCodeAuditLogFormatter.php
Outdated
Show resolved
Hide resolved
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
This is looking good but shouldn't we see the new formatters registered in config/audit_log.php?
Also, SummitTaxTypeAuditLogFormatter and SummitRefundPolicyTypeAuditLogFormatter are scaling rates incorrectly by multiplying by 100 before rendering, but these are already stored as percentage points (e.g., 21.0, 90.5). This causes audit logs to report inflated values (e.g., 2100% instead of 21%). Remove the extra * 100 in formatter output. The corresponding tests (SummitTaxTypeAuditLogFormatterTest, SummitRefundPolicyTypeAuditLogFormatterTest) also use decimal-fraction mock values
(e.g., 0.21, 1.0, 0.5) instead of real-world percentage-point values (e.g., 21.0, 100.0, 50.0).
|
Ready to review @caseylocker |
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
LGTM but needs to have the merge conflicts fixed before merging.
andrestejerina97
force-pushed
the
feature/add-ticket-formatters
branch
from
2697d22 to
2db0afa
Compare
app/Audit/ConcreteFormatters/PrePaidSummitRegistrationDiscountCodeAuditLogFormatter.php
Show resolved
Hide resolved
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please review coments
|
it's ready to review |
andrestejerina97
force-pushed
the
feature/add-ticket-formatters
branch
from
c2edc6f to
b1be8b2
Compare
tests/OpenTelemetry/Formatters/SummitRefundPolicyTypeAuditLogFormatterTest.php
Outdated
Show resolved
Hide resolved
tests/OpenTelemetry/Formatters/PrePaidSummitRegistrationDiscountCodeAuditLogFormatterTest.php
Outdated
Show resolved
Hide resolved
tests/OpenTelemetry/Formatters/SummitTaxTypeAuditLogFormatterTest.php
Outdated
Show resolved
Hide resolved
tests/OpenTelemetry/Formatters/SummitTicketTypeAuditLogFormatterTest.php
Outdated
Show resolved
Hide resolved
tests/OpenTelemetry/Formatters/PrePaidSummitRegistrationDiscountCodeAuditLogFormatterTest.php
Show resolved
Hide resolved
tests/OpenTelemetry/Formatters/SummitTicketTypeAuditLogFormatterTest.php
Show resolved
Hide resolved
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please review comments
matiasperrone-exo
force-pushed
the
feature/add-ticket-formatters
branch
from
b1be8b2 to
133388c
Compare
|
Thank you for the comments. 
|
5 participants
Task
Ref: https://app.clickup.com/t/86b8acw9f