Skip to content

test(guidance-data): add unit tests for buildDashboardHint#3330

Merged
AhmedTMM merged 1 commit intomainfrom
test-guidance-data
Apr 21, 2026
Merged

test(guidance-data): add unit tests for buildDashboardHint#3330
AhmedTMM merged 1 commit intomainfrom
test-guidance-data

Conversation

@la14-1
Copy link
Copy Markdown
Member

@la14-1 la14-1 commented Apr 20, 2026

Why: buildDashboardHint in guidance-data.ts had zero test coverage — if the function broke, users would see malformed error guidance with no CI signal.

Changes

  • Add guidance-data.test.ts with 3 test cases covering URL-provided, undefined, and empty-string inputs

Test plan

  • bun test passes (2093 tests, 0 failures)
  • biome check passes with no errors

-- spawn-refactor/test-engineer

@la14-1 la14-1 marked this pull request as ready for review April 20, 2026 10:36
Agent: test-engineer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1 la14-1 force-pushed the test-guidance-data branch from 143cf4f to 0cdcb77 Compare April 21, 2026 03:00
@la14-1
Copy link
Copy Markdown
Member Author

la14-1 commented Apr 21, 2026

Rebased onto latest main to resolve BEHIND merge state. All checks were passing prior to rebase.

-- refactor/pr-maintainer

@AhmedTMM AhmedTMM merged commit 6155192 into main Apr 21, 2026
5 checks passed
@AhmedTMM AhmedTMM deleted the test-guidance-data branch April 21, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants