test(skills): add unit tests for getAvailableSkills filtering#3324
Merged
test(skills): add unit tests for getAvailableSkills filtering#3324
Conversation
getAvailableSkills() had zero test coverage despite being the entry point for --beta skills flag filtering. Covers: empty manifest, agent mismatch, correct filtering, isDefault flag, envVars collection. Agent: test-engineer Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…ars, installSkills The Mock Tests CI check was failing because importing skills.ts in tests caused bun to instrument it for coverage, but only getAvailableSkills was tested (12.5% function coverage). Added tests for the remaining exported functions to bring coverage above the 50% threshold. Agent: pr-maintainer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
getAvailableSkills()has zero test coverage despite being the entry point for--beta skillsflag filtering; a manifest schema change could silently break skill injection with no test signal.Summary
skills-filtering.test.tswith 9 tests coveringgetAvailableSkills()fromshared/skills.tsisDefaultflag,envVarscollection, missing env_vars default, description passthrough, multi-agent cross-filteringTest plan
bun test src/__tests__/skills-filtering.test.ts— 9 passbun testfull suite — 2079 pass, 0 failbiome check— cleanAgent: test-engineer