Skip to content

fix(ux): replace stale 'spawn connect' hints with 'spawn last'#3312

Merged
AhmedTMM merged 5 commits intomainfrom
fix/spawn-connect-hints
Apr 19, 2026
Merged

fix(ux): replace stale 'spawn connect' hints with 'spawn last'#3312
AhmedTMM merged 5 commits intomainfrom
fix/spawn-connect-hints

Conversation

@la14-1
Copy link
Copy Markdown
Member

@la14-1 la14-1 commented Apr 16, 2026

Why: `spawn connect` is not a registered CLI command — users following the Daytona reconnect hint in `list.ts` and the SSH failure hint in `connect.ts` get "Unknown agent or cloud: connect". Both were missed by #3311 which fixed the same issue in `orchestrate.ts`.

Changes:

  • `commands/list.ts`: Daytona reconnect hint → `spawn last`
  • `commands/connect.ts`: SSH failure "try manually" hint → `spawn last`
  • `orchestrate.test.ts`: stale comment updated
  • `package.json`: patch version bump (1.0.15 → 1.0.16)

-- refactor/code-health

Two user-facing reconnect hints missed by #3311 still showed
'spawn connect <name>', which is not a registered command. Users
following the hint get 'Unknown agent or cloud: connect'.

Agent: code-health
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Copy link
Copy Markdown
Member Author

@la14-1 la14-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security review (spawn-bot): Safe to merge. Only changes string literals in CLI hint messages — spawn connectspawn last. No logic changes, no new inputs, no command execution. CI green. Needs approval from a different reviewer since this is my own PR.

@la14-1
Copy link
Copy Markdown
Member Author

la14-1 commented Apr 18, 2026

All CI checks pass. Security reviewed (no risk — only string literal changes). Ready to merge but blocked: I (la14-1) am the author and cannot self-approve per repo rules. Needs approval from another team member with write access (e.g. @AhmedTMM).

@la14-1
Copy link
Copy Markdown
Member Author

la14-1 commented Apr 19, 2026

PR health check (stale 3+ days): Still valid and needed. Verified that all 3 stale spawn connect references remain on main (connect.ts:171, list.ts:628, orchestrate.test.ts:911). All CI checks pass. Changes are minimal string literal fixes — no conflicts.

Needs approval from a reviewer other than the PR author to merge.

-- refactor/pr-maintainer

Copy link
Copy Markdown
Collaborator

@AhmedTMM AhmedTMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — CI green.

@AhmedTMM AhmedTMM merged commit 97c0732 into main Apr 19, 2026
5 checks passed
@AhmedTMM AhmedTMM deleted the fix/spawn-connect-hints branch April 19, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants