test(cli): cover diff cli_utils path normalization and install detection#333
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(cli): cover diff cli_utils path normalization and install detection#333cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…n tests Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Contributor
|
Message that will be displayed on users' first pull request |
Contributor
🔨 Build Validation Summary✅ Version Check: Passed Tool Builds
🎉 All builds validated successfully! This PR is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests for
pykotor.diff_tool.cli_utils, which was updated in the case-aware path work (#151) but had no direct test coverage.Risky behavior now covered
normalize_path_arg: PowerShell quoting edge cases (mangled"concatenation, embedded quotes, trailing backslashes) that break diff/patch CLI path inputs on Windows.is_kotor_install_dir: Case-aware install detection viachitin.keylookup — used by diff, patching, and TSLPatcher diff engine to route installation-vs-file comparisons.Test files added/updated
Libraries/PyKotor/tests/cli/test_diff_cli_utils.py(new, 15 tests)Why these tests materially reduce regression risk
is_kotor_install_dirimplementations (cli_utils,patching,tslpatcher.diff.engine) are asserted in parallel so a future refactor cannot silently diverge.normalize_path_argparametrized cases lock in the quoting fixes that prevent CLI failures when users pass paths with spaces from PowerShell.Validation