test: cover case-aware install detection and CI json export progress#332
Draft
cursor[bot] wants to merge 2 commits into
Draft
test: cover case-aware install detection and CI json export progress#332cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…ation Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Contributor
|
Message that will be displayed on users' first pull request |
Contributor
🔨 Build Validation Summary✅ Version Check: Passed Tool Builds
🎉 All builds validated successfully! This PR is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests for recently merged production changes that lacked direct coverage.
Risky behavior now covered
is_kotor_install_dirindiff_tool/cli_utils,tools/patching, andtslpatcher/diff/engine): verifieschitin.keyis found even when directory or key casing differs on case-sensitive filesystems (the behavior introduced in Case-aware application #151).normalize_path_arg): guards against quote-escape mangling and trailing-slash issues that break diff/CLI path inputs on Windows._supports_live_progress/_ExportProgressReporter): ensures automation env vars (CI,GITHUB_ACTIONS) disable live\rstderr updates and route progress through logger output instead (fix from json-export regression).Test files added/updated
Libraries/PyKotor/tests/diff_tool/test_cli_utils.py(new, 7 tests)Libraries/PyKotor/tests/cli/test_resource_json_progress.py(new, 11 tests)Why these tests materially reduce regression risk
Install-directory detection is on the critical path for diff, patch, and CLI workflows; a regression would silently treat valid game roots as invalid. Path normalization bugs are a common Windows support issue. CI progress behavior affects observability in GitHub Actions — live TTY updates bypass structured logging and break caplog-based tests.
Validation
All 18 tests pass.