fix(ci): stop verify-pypi cancel storm on master#275
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8633e55aa1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if: ${{ github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success' }} | ||
| name: Generate Report | ||
| runs-on: ubuntu-latest | ||
| needs: [test-pykotor-core, test-pykotor-extensions, test-cli-tools] |
There was a problem hiding this comment.
if key in report job
The report job now defines if twice, first with the new workflow_run success guard and then again as if: always(). In YAML mappings, duplicate keys do not both apply, so the latter if: always() effectively overrides the new guard; this means runs triggered by unsuccessful Auto-Publish to PyPI completions will still execute report, which contradicts the stated goal of skipping jobs for non-success workflow_run events and continues to consume CI runs.
Useful? React with 👍 / 👎.
1 participant
Summary
cancel-in-progress: falseon Verify PyPI Regression concurrency group.workflow_runof Auto-Publish did not succeed.Test plan