Job code AI assistant: Show statuses streamed after the text answer#4833
Merged
Conversation
Security Review ✅
|
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4833 +/- ##
=======================================
- Coverage 90.3% 90.3% -0.0%
=======================================
Files 444 444
Lines 22577 22577
=======================================
- Hits 20393 20392 -1
- Misses 2184 2185 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add AIChannelRegistry tests driving the streaming_chunk path: a text chunk over the wire clears an active status, and a status streamed after the text survives the char-by-char drain. Also dedupe the bouncing-dots indicator into a small shared component in MessageList.
Fold the last inline copy of the dots into the shared component, so all three indicators (pre-text loading, post-text status, processing) use it.
elias-ba
approved these changes
Jun 9, 2026
elias-ba
left a comment
Contributor
There was a problem hiding this comment.
Approving, this is a clean fix. Nice job @hanna-paasivirta. I pushed two small additions on top: a test in AIChannelRegistry covering the streaming_chunk path end to end, and pulled the bouncing-dots indicator into a shared component now used by all three indicators
Contributor
|
Hey @josephjclark can you merge this when you have time |
josephjclark
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If Apollo streams a thinking status (e.g. "Writing code…") after the text answer while job code is still being generated, it will now be displayed below the answer using the same indicator style as the pre-text "Thinking…" status.
Closes #4832
Currently the order of events from Apollo when there are code changes is strictly stream status -> text -> stream status -> code. However, I tried to implement this in a way that will also work if we add more interleaved text/stream statuses.
Validation steps
-> streaming statuses
-> text explanation of what the assistant is going to do
-> new: another streaming status
-> code diffs are noted in the chat and displayed the code.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)