[backend] feat(audit-logging): avoid fetching user to improv performance (#5480)#5921
Open
RomuDeuxfois wants to merge 1 commit into
Open
[backend] feat(audit-logging): avoid fetching user to improv performance (#5480)#5921RomuDeuxfois wants to merge 1 commit into
RomuDeuxfois wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the OpenAEVPrincipal abstraction to expose the authenticated user’s email directly from the security principal, which supports avoiding additional User fetches in downstream concerns like audit logging.
Changes:
- Add
getEmail()toOpenAEVPrincipal. - Implement
getEmail()across SAML/OIDC/OAuth2 principals andDefaultOpenAEVPrincipal. - Extend
DefaultOpenAEVPrincipalto carry the email value.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| openaev-api/src/main/java/io/openaev/config/OpenAEVSaml2User.java | Delegate getEmail() to underlying User. |
| openaev-api/src/main/java/io/openaev/config/OpenAEVPrincipal.java | Add getEmail() to the principal contract. |
| openaev-api/src/main/java/io/openaev/config/OpenAEVOidcUser.java | Delegate getEmail() to underlying User. |
| openaev-api/src/main/java/io/openaev/config/OpenAEVOAuth2User.java | Delegate getEmail() to underlying User. |
| openaev-api/src/main/java/io/openaev/config/OpenAEVAnonymous.java | Implement getEmail() for anonymous principal (currently returns null). |
| openaev-api/src/main/java/io/openaev/config/DefaultOpenAEVPrincipal.java | Store email and expose it via getEmail(); constructor signature updated. |
783fc66 to
bd31ea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.