Skip to content

[Client] Use TransportQuotas from ApplicationConfiguration in CoreClientUtils for creating EndpointConfiguration #3181

Merged
marcschier merged 4 commits into
OPCFoundation:masterfrom
romanett:feat/clientFixes
Sep 9, 2025
Merged

[Client] Use TransportQuotas from ApplicationConfiguration in CoreClientUtils for creating EndpointConfiguration #3181
marcschier merged 4 commits into
OPCFoundation:masterfrom
romanett:feat/clientFixes

Conversation

@romanett

@romanett romanett commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Proposed changes

Use TransportQuotas from ApplicationConfiguration in CoreClientUtils for creating EndpointConfiguration.
This fixes that TransportQuotas from ApplicationConfiguration are not used for the created Endpoints.

For the Discovery Client the default TransportQuotas are still used.

Related Issues

  • Fixes #

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@codecov

codecov Bot commented Sep 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.65%. Comparing base (520351c) to head (69bfaba).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3181      +/-   ##
==========================================
- Coverage   58.03%   57.65%   -0.39%     
==========================================
  Files         356      354       -2     
  Lines       78102    78088      -14     
  Branches    13817    13817              
==========================================
- Hits        45330    45021     -309     
- Misses      28599    28839     +240     
- Partials     4173     4228      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanett romanett changed the title [Client] Use TransportQuotas from ApplicationConfiguration in CoreClientUtils for creating EndpointConfiguration [Client] Use TransportQuotas from ApplicationConfiguration in CoreClientUtils for creating EndpointConfiguration / Add toNodeTable Method to NodeCache Sep 3, 2025
Comment thread Libraries/Opc.Ua.Client/NodeCache/INodeCache.cs Outdated
@romanett romanett changed the title [Client] Use TransportQuotas from ApplicationConfiguration in CoreClientUtils for creating EndpointConfiguration / Add toNodeTable Method to NodeCache [Client] Use TransportQuotas from ApplicationConfiguration in CoreClientUtils for creating EndpointConfiguration Sep 3, 2025
@romanett
romanett requested a review from marcschier September 5, 2025 11:52
@romanett romanett added this to the 1.5.378 Async Server Update 2 milestone Sep 7, 2025
@marcschier
marcschier merged commit d8d4c74 into OPCFoundation:master Sep 9, 2025
76 of 77 checks passed
@romanett
romanett deleted the feat/clientFixes branch September 13, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants