Skip to content

[9.0][website_snippet_big_button] Migrate - #303

Merged
pedrobaeza merged 3 commits into
OCA:9.0from
Tecnativa:9.0-website_snippet_big_button-mig
Dec 23, 2016
Merged

[9.0][website_snippet_big_button] Migrate#303
pedrobaeza merged 3 commits into
OCA:9.0from
Tecnativa:9.0-website_snippet_big_button-mig

Conversation

@yajo

@yajo yajo commented Dec 21, 2016

Copy link
Copy Markdown
Member
  • Delete CSS source.
  • Use new snippets & snippet options API.
  • New JS API.
  • Follow guidelines and put templates under templates/
  • LGPL.

@Tecnativa @cubells

@cubells cubells left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Tested on runbot

@rafaelbn rafaelbn added this to the 9.0 milestone Dec 21, 2016

@rafaelbn rafaelbn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Jairo Llopis and others added 3 commits December 22, 2016 14:05
- Delete CSS source.
- Use new snippets & snippet options API.
- New JS API.
- Follow guidelines and put templates under `templates/`
- LGPL.
@pedrobaeza
pedrobaeza force-pushed the 9.0-website_snippet_big_button-mig branch from 4f3c7de to 42201fe Compare December 22, 2016 13:06
@pedrobaeza

Copy link
Copy Markdown
Member

@yajo, Travis has started to fail again

@yajo

yajo commented Dec 23, 2016

Copy link
Copy Markdown
Member Author

OCA/server-tools#666 should fix it if I'm not wrong.

@pedrobaeza

Copy link
Copy Markdown
Member

@yajo, tests in website are still red although the patch, and there's also an error in website_seo_redirection tests.

@pedrobaeza

Copy link
Copy Markdown
Member

Solving server-tools problem has fixed the other problem, so this one is good to go also!

@pedrobaeza
pedrobaeza merged commit cfa6619 into OCA:9.0 Dec 23, 2016
@pedrobaeza
pedrobaeza deleted the 9.0-website_snippet_big_button-mig branch December 23, 2016 22:04
@pedrobaeza pedrobaeza mentioned this pull request Dec 23, 2016
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants