Skip to content

10.0 migrate auth_supplier#793

Merged
yajo merged 2 commits into
OCA:10.0from
StephanRozendaal:10.0-mig-auth_supplier
May 31, 2017
Merged

10.0 migrate auth_supplier#793
yajo merged 2 commits into
OCA:10.0from
StephanRozendaal:10.0-mig-auth_supplier

Conversation

@StephanRozendaal

Copy link
Copy Markdown

Migrate the auth_supplier module to 10.0

oca-transbot and others added 2 commits March 25, 2017 15:34
Changes include:
 - bump version number
 - fix Python imports
 - update README
@pedrobaeza pedrobaeza mentioned this pull request Mar 25, 2017
63 tasks
@lasley lasley added this to the 10.0 milestone Mar 25, 2017
'name': "Auth Supplier",
'category': 'Portal',
'version': '9.0.2.0.0',
'version': '10.0.1.0.0',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's correct as it is. The subversion should be reset on each new Odoo version.

@Fenkiou Fenkiou May 13, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is non sense. Odoo releasing a version each year, modules won't have same version despite sharing exact same code.

Also, referring to this, there is no indication on resetting the module version.

The two first digits are just here to tell that the module can be installed only on a specific odoo version.

For this module, the version should even be 10.0.2.1.0 if you consider adding new translations is a feature.

EDIT: Forget my last sentence as it's transbot that produced the translation files and I guess the files are presents on version 9.0 too. Even if I think that new languages should bump version number too. :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0#tasks-to-do-in-the-migration with the reference for the change of the version, and there's a rationale after this decision that is too large to explain here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, missed that one, sorry. I would like to read the discussion on how this decision came up if you have a link.

@Fenkiou Fenkiou May 13, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found the issue talking about that, deleting my comment ;)

EDIT: Though deleting my comment would delete all comments but no :/
The first comment was:

Module version was 2.0.0, it should not be downgraded

EDIT2: In fact, I'm not sure this issue is related to the decision taken

@Tardo Tardo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me... and I need it for migrate 'website_portal_purchase' to v10.0

@yajo yajo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK

@felixvillafranca felixvillafranca left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now a field "Account Type" appears in the sign up form; but when sign up an error occurs:

screenshot 2017-05-30 at 17 47 13

@Tardo

Tardo commented May 30, 2017

Copy link
Copy Markdown
Member

@felixvillafranca For some reason not show "Password" and "Confirm Password"... In local works fine.

signup

@pedrobaeza

Copy link
Copy Markdown
Member

Check if there's any conflicting module

@felixvillafranca

Copy link
Copy Markdown

Hi Tardo;
I've been checking your module; and you're rigth, the module is Ok..
Password and confirm password were hidden due to "auth_signup_verify_email" was installed.
And becuase of the outgoing mail server wasn't not configured it failed.

So, excuse me and thanks for your work.

@felixvillafranca felixvillafranca left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

@yajo
yajo merged commit 8dd5c7d into OCA:10.0 May 31, 2017
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
…non-bump-minor

Syncing from upstream OCA/server-tools (14.0-ocabot-merge-pr-2189-by-lmignon-bump-minor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants