Improve readme and fix dep#733
Merged
Merged
Conversation
Readme: (in example) prefix function with _ Dep: add a depency to base_setup in order to use xml id "base.menu_config"
Contributor
|
👍 |
Member
|
Please remove base, if you add base_setup. Otherwise, 👍 |
Remove explicit dependency to base.
Contributor
Author
Fixed. Thanks for your reviews |
Member
|
Why several commits here, for 2 lines ? --force |
Contributor
Author
|
--forcing a push on a public branch is not a good thing |
tafaRU
approved these changes
Feb 16, 2017
tafaRU
left a comment
tafaRU
left a comment
Member
There was a problem hiding this comment.
LGTM even though I'd prefer commits to be squashed to only one.
Contributor
|
thanks. |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (13.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1° Readme: (in example) prefix function with _
2° Dep: add a depency to base_setup in order to use xml id "base.menu_config" in https://github.com/OCA/server-tools/blob/9.0/keychain/views/keychain_view.xml#L47