Skip to content

[MIG]Migrated base_export_manager module.#712

Closed
maulik-raval wants to merge 3 commits into
OCA:10.0from
maulik-raval:10.0
Closed

[MIG]Migrated base_export_manager module.#712
maulik-raval wants to merge 3 commits into
OCA:10.0from
maulik-raval:10.0

Conversation

@maulik-raval

Copy link
Copy Markdown

No description provided.

@pedrobaeza pedrobaeza mentioned this pull request Jan 24, 2017
63 tasks
@maulik-raval maulik-raval reopened this Jan 25, 2017
@mourad-ehm

Copy link
Copy Markdown
Contributor

Code review 👍

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaelbn

Copy link
Copy Markdown
Member

Hi @maulik-raval-serpentcs are you going to continue this PR correctly? Thanks

@yvaucher

Copy link
Copy Markdown
Member

I will be working on this to repair the missing commits

@yajo

yajo commented Jun 16, 2017

Copy link
Copy Markdown
Member

Long time no answer, closing; I'll retake.

@yajo yajo closed this Jun 16, 2017
@yvaucher

Copy link
Copy Markdown
Member

@yajo Did you see my comment ?

@yajo

yajo commented Jun 16, 2017

Copy link
Copy Markdown
Member

woah missed it, I've got the commits, will push here then

@yajo yajo reopened this Jun 16, 2017
@yvaucher

Copy link
Copy Markdown
Member

By the way it seems that the only missing commits are translation updates or am I missing something ?

@yvaucher

Copy link
Copy Markdown
Member

@yajo anyway we need to create a new pull request I don't have the write access on this one from serpent CS

@yajo

yajo commented Jun 16, 2017

Copy link
Copy Markdown
Member

OK, I overwrote this branch to get the translations. I do have write access, so we can close it or continue here, what do you prefer?

@yvaucher

Copy link
Copy Markdown
Member

What you prefer. I have no additional change that those update translation commits you already did

@yajo yajo self-assigned this Jun 16, 2017
@yajo yajo added this to the 10.0 milestone Jun 16, 2017
@yajo

yajo commented Jun 16, 2017

Copy link
Copy Markdown
Member

OK, It's done now so let's continue here. Reviews please! 😊

@pedrobaeza

Copy link
Copy Markdown
Member

I think there are changes in 8.0 that are not reflected here (you need to check also that branch).

@yajo

yajo commented Jun 16, 2017

Copy link
Copy Markdown
Member

Let me see.

@yajo

yajo commented Jun 16, 2017

Copy link
Copy Markdown
Member

Yikes, branches 8 and 9 evolved in different ways...

I'll close and open a new PR once all is in, sorry for the noise.

@yajo

yajo commented Jun 22, 2017

Copy link
Copy Markdown
Member

New PR: #870

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants