[MIG] Port base_user_role to 10.0 by adrienpeiffer · Pull Request #684 · OCA/server-tools

adrienpeiffer · 2017-01-02T17:52:51Z

No description provided.

…CA#608) * [ADD] New module 'base_user_role' * [FIX] base_user_role - Review * [FIX] base_user_role - Review s/is_active/is_enabled/ * [FIX] base_user_role - Review s/is_active/is_enabled/ * [IMP] base_user_role - Translations updated (template + FR) * [FIX] base_user_role - Lint

[IMP] base_user_role - Replace '<openerp>' tags by '<odoo>' + Remove useless '<data>' tags + Reindent XML content [FIX] base_user_role - Fix noupdate declaration [REM] base_user_role - Remove old migration script

sebalix

Thank you for the migration! Minor changes to the unit tests about variable names and list comprehensions to remove, but non-blocking. 👍

sebalix · 2017-01-02T18:47:54Z

-        self.group_no_one_id = self.imd_model.get_object_reference(
-            self.cr, self.uid, 'base', 'group_no_one')[1]
+        self.group_user_id = self.env.ref('base.group_user')
+        self.group_no_one_id = self.env.ref('base.group_no_one')


s/group_user_id/group_user/
s/group_no_one_id/group_no_one/

sebalix · 2017-01-02T18:48:28Z

-            self.cr, self.uid, 'base', 'group_sale_manager')[1]
+        self.group_multi_currency_id = self.env.ref(
+            'base.group_multi_currency')
+        self.group_settings_id = self.env.ref('base.group_system')


s/group_settings_id/group_settings/

sebalix · 2017-01-02T18:48:57Z

+        self.user_model = self.env['res.users']
+        self.role_model = self.env['res.users.role']

        self.user_id = self.user_model.create(


s/user_id/user/

sebalix · 2017-01-02T18:50:23Z

-        role1_group_ids = role1.implied_ids.ids
-        role1_group_ids.append(role1.group_id.id)
+        user_group_ids = sorted(set(
+            [group.id for group in self.user_id.groups_id]))


user_group_ids = sorted(set(self.user.groups_id.ids))

sebalix · 2017-01-02T18:51:48Z

            'name': u"ROLE_1",
-            'implied_ids': [6, 0, [self.group_user_id, self.group_no_one_id]],
+            'implied_ids': [6, 0, [self.group_user_id.id,
+                                   self.group_no_one_id.id]],


[self.group_user.id, self.group_no_one.id]

sebalix · 2017-01-02T18:52:18Z

+                                   self.group_no_one_id.id]],
        }
-        self.role1_id = self.role_model.create(self.cr, self.uid, vals)
+        self.role1_id = self.role_model.create(vals)


s/role1_id/role1/

sebalix · 2017-01-02T18:52:46Z

+                                   self.group_settings_id.id]],
        }
-        self.role2_id = self.role_model.create(self.cr, self.uid, vals)
+        self.role2_id = self.role_model.create(vals)


s/role2_id/role2/

sebalix · 2017-01-02T18:53:38Z

+        self.user_id.write(
+            {'role_line_ids': [(0, 0, {'role_id': self.role2_id.id})]})
+        user_group_ids = sorted(set(
+            [group.id for group in self.user_id.groups_id]))


user_group_ids = sorted(set(self.user_id.groups_id.ids))

sebalix · 2017-01-02T18:56:20Z

+        self.user_id.write(
+            {'role_line_ids': [(0, 0, {'role_id': self.role1_id.id})]})
+        user_group_ids = sorted(set(
+            [group.id for group in self.user_id.groups_id]))


user_group_ids = sorted(set(self.user.groups_id.ids))

jcdrubay

Only 2 small comments. Thanks for the contribution. I hope it can be merged soon. :)

jcdrubay · 2017-01-22T15:29:49Z

+# OCA Transbot <transbot@odoo-community.org>, 2016
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 9.0c\n"


Seems like it is a wrong version here.

I'm fairly certain this won't be an issue. Something something, automation is amazing

jcdrubay · 2017-01-22T15:31:59Z

+    <field name="name">res.users.role.form</field>
+    <field name="model">res.users.role</field>
+    <field name="arch" type="xml">
+        <form string="Role" version="7.0">


It should be time to remove the version="7.0"

lasley

Thanks @adrienpeiffer

Can you please remove the version as noted by @jcdrubay & squash the commits? Good for merge after those tiny details 👍

lasley · 2017-02-08T19:08:00Z

+# OCA Transbot <transbot@odoo-community.org>, 2016
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 9.0c\n"


I'm fairly certain this won't be an issue. Something something, automation is amazing

adrienpeiffer · 2017-02-09T18:03:22Z

@lasley @jcdrubay Thanks for the review !

lasley · 2017-02-10T15:56:25Z

@adrienpeiffer - Dang, looks like the last round of edits made CI 🔴 - https://travis-ci.org/OCA/server-tools/jobs/200071164#L720

adrienpeiffer · 2017-02-10T18:36:41Z

It should be better now 💚

rousseldenis · 2017-02-17T12:24:36Z

Ready to be merged ?

adrienpeiffer · 2017-02-17T13:06:23Z

GO 😃

Syncing from upstream OCA/server-tools (8.0)

sebalix and others added 4 commits January 2, 2017 18:08

base_user_role - Bump module version to '9.0.1.0.0'

e4b9e67

[IMP] base_user_role - Replace '<openerp>' tags by '<odoo>' + Remove useless '<data>' tags + Reindent XML content [FIX] base_user_role - Fix noupdate declaration [REM] base_user_role - Remove old migration script

base_user_role: display roles as first tab in user form

e4188f2

base_user_role - Set a default category to associated groups

e6a0204

pedrobaeza mentioned this pull request Jan 2, 2017

Migration to version 10.0 #565

Closed

63 tasks

sebalix approved these changes Jan 2, 2017

View reviewed changes

lasley added the needs review label Jan 15, 2017

lasley added this to the 10.0 milestone Jan 15, 2017

jcdrubay approved these changes Jan 22, 2017

View reviewed changes

lasley approved these changes Feb 8, 2017

View reviewed changes

adrienpeiffer force-pushed the 10.0-mig-base_user_role-ape branch from 5c5282d to 27bc2c5 Compare February 9, 2017 18:02

oca-transbot and others added 2 commits February 17, 2017 08:04

OCA Transbot updated translations from Transifex

7601436

[MIG] base_user_role: Port to 10.0

d2a6e8e

lasley force-pushed the 10.0-mig-base_user_role-ape branch from 3eb409e to d2a6e8e Compare February 17, 2017 16:04

lasley merged commit 49b6e9c into OCA:10.0 Feb 17, 2017

sbidoul deleted the 10.0-mig-base_user_role-ape branch February 17, 2017 16:07

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#684 from OCA/8.0

d9d63d7

Syncing from upstream OCA/server-tools (8.0)

Uh oh!

Uh oh!

Conversation

adrienpeiffer commented Jan 2, 2017

Uh oh!

sebalix left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcdrubay left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lasley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adrienpeiffer commented Feb 9, 2017

Uh oh!

lasley commented Feb 10, 2017

Uh oh!

adrienpeiffer commented Feb 10, 2017

Uh oh!

rousseldenis commented Feb 17, 2017

Uh oh!

adrienpeiffer commented Feb 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants