Migrate mail_environment to 10.0#662
Merged
Merged
Conversation
guewen
force-pushed
the
mig_10.0-mail_environment
branch
from
December 21, 2016 16:28
d489e73 to
e727653
Compare
yvaucher
force-pushed
the
mig_10.0-mail_environment
branch
from
March 23, 2017 12:57
e727653 to
0fada76
Compare
yvaucher
approved these changes
Mar 23, 2017
Member
|
Tested and code LGTM |
Contributor
|
Could you fix |
Member
|
@moylop260 this is a no for 4 spaces in xml files it was discussed long ago and people were mostly in favor of 2 spaces but for history reasons we didn't enforced it. There are at least 554 xml files in OCA with 2 space indentation. |
moylop260
approved these changes
Mar 24, 2017
gurneyalex
force-pushed
the
mig_10.0-mail_environment
branch
from
April 6, 2017 14:18
435f1fa to
53f9338
Compare
leemannd
approved these changes
Apr 6, 2017
Contributor
|
@gurneyalex @guewen Could be merged? |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (14.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
need #595