10.0 Migrate users_ldap_mail module - #651
Merged
Merged
Conversation
lasley
reviewed
Dec 17, 2016
| @@ -0,0 +1,317 @@ | |||
| # Translation of Odoo Server. | |||
Contributor
There was a problem hiding this comment.
Please delete auto_backup files
StephanRozendaal
force-pushed
the
10.0-mig-users-ldap-mail
branch
from
December 17, 2016 19:37
1fd9dcb to
a8a6c03
Compare
Author
|
I removed the "auto_backup" translation commit |
StephanRozendaal
force-pushed
the
10.0-mig-users-ldap-mail
branch
2 times, most recently
from
December 17, 2016 20:52
163ea7f to
26780a2
Compare
Changes in models/users_ldap_mail include: - remove unused imports - indentation of too long lines
StephanRozendaal
force-pushed
the
10.0-mig-users-ldap-mail
branch
from
December 17, 2016 22:35
26780a2 to
ebc46f1
Compare
dreispt
requested changes
Dec 22, 2016
dreispt
left a comment
dreispt
left a comment
Member
There was a problem hiding this comment.
Looks good, other than the comments made.
|
|
||
| .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/{server-tools}/{10.0} |
| ############################################################################## | ||
|
|
||
| from . import users_ldap_model | ||
| from . import models |
Member
There was a problem hiding this comment.
It would be great if you could replace the old large copyright statement with the new leaner one.
| help="By default 'cn' is used. " | ||
| "For ActiveDirectory you might use 'displayName' instead.") | ||
| mail_attribute = fields.Char( | ||
| 'E-mail attribute', size=64, _defaults='mail', |
Member
There was a problem hiding this comment.
Remove the size attribute from char fields
| ldaps = self.sudo().search([('ldap_server', '!=', False)], | ||
| order='sequence') | ||
| res = ldaps.read([]) | ||
| return res |
users_ldap_mail/models/__init__.py should be UTF-8 encoded
Fixes included: - Make module name human readable - Instead of numbering steps, use # - Update broken link
dreispt
approved these changes
Dec 27, 2016
lasley
approved these changes
Dec 27, 2016
lasley
left a comment
lasley
left a comment
Contributor
There was a problem hiding this comment.
Thanks @StephanRozendaal - 👍 , although some more test coverage would be awesome
sebalix
pushed a commit
to osiell/server-tools
that referenced
this pull request
Jan 23, 2017
* [ADD] Add README.rst to users_ldap_mail * [MIG] Migrate users_ldap_mail to 10.0 * [FIX] Fixes in code style in module users_ldap_mail Changes in models/users_ldap_mail include: - remove unused imports - indentation of too long lines * [FIX] users_ldap_mail: Fix copyright notice * [FIX] users_ldap_mail: set UTF-8 encoding users_ldap_mail/models/__init__.py should be UTF-8 encoded * [FIX] users_ldap_mail: remove size argument from Char fields * [FIX] users_ldap_mail: return value can be combined in one line * [FIX] Update read me Fixes included: - Make module name human readable - Instead of numbering steps, use # - Update broken link
etobella
pushed a commit
to etobella/server-tools
that referenced
this pull request
Oct 9, 2017
* [ADD] Add README.rst to users_ldap_mail * [MIG] Migrate users_ldap_mail to 10.0 * [FIX] Fixes in code style in module users_ldap_mail Changes in models/users_ldap_mail include: - remove unused imports - indentation of too long lines * [FIX] users_ldap_mail: Fix copyright notice * [FIX] users_ldap_mail: set UTF-8 encoding users_ldap_mail/models/__init__.py should be UTF-8 encoded * [FIX] users_ldap_mail: remove size argument from Char fields * [FIX] users_ldap_mail: return value can be combined in one line * [FIX] Update read me Fixes included: - Make module name human readable - Instead of numbering steps, use # - Update broken link
etobella
pushed a commit
to etobella/server-tools
that referenced
this pull request
Oct 10, 2017
* [ADD] Add README.rst to users_ldap_mail * [MIG] Migrate users_ldap_mail to 10.0 * [FIX] Fixes in code style in module users_ldap_mail Changes in models/users_ldap_mail include: - remove unused imports - indentation of too long lines * [FIX] users_ldap_mail: Fix copyright notice * [FIX] users_ldap_mail: set UTF-8 encoding users_ldap_mail/models/__init__.py should be UTF-8 encoded * [FIX] users_ldap_mail: remove size argument from Char fields * [FIX] users_ldap_mail: return value can be combined in one line * [FIX] Update read me Fixes included: - Make module name human readable - Instead of numbering steps, use # - Update broken link
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (13.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes include: