[10.0] [MIG] Migration of server_environment_ir_config_parameter#640
Merged
guewen merged 6 commits intoJun 21, 2017
Merged
Conversation
rousseldenis
changed the title
rousseldenis
changed the title
Member
|
@rousseldenis can you please forward port this too #676 ? |
sbidoul
reviewed
Dec 28, 2016
| else: | ||
| newvals = vals | ||
| super(IrConfigParameter, rec).write(newvals) | ||
| return super(IrConfigParameter, rec).write(newvals) |
Member
There was a problem hiding this comment.
@rousseldenis this does not look right. The write must be inside the loop as we overwrite whatever is provided in vals with the values found in the config file, so each property may end up with a different value. So this commit changes the expected behaviour.
sbidoul
reviewed
Dec 28, 2016
| newvals = vals | ||
| return super(IrConfigParameter, rec).write(newvals) | ||
| super(IrConfigParameter, rec).write(newvals) | ||
| return True |
Member
There was a problem hiding this comment.
Ah yes, fixed in next commit, okay.
Contributor
|
This one depends of #595 |
Contributor
sbidoul
force-pushed
the
10.0-mig-server_environment_ir_config_parameter-dro
branch
from
March 31, 2017 13:42
7f675f8 to
e04e420
Compare
Member
|
rebased |
… values This is much more robust that raising an error, and let modules load ir.config_parameter from xml data files, while still enforcing values from the config files.
sbidoul
force-pushed
the
10.0-mig-server_environment_ir_config_parameter-dro
branch
from
March 31, 2017 14:34
8af6cda to
35da9d6
Compare
Member
|
This one is now finished and migrated to new API. |
simahawk
approved these changes
Jun 21, 2017
leemannd
approved these changes
Jun 21, 2017
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (8.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.