Skip to content

[MIG][10.0] auto_backup - #614

Merged
lasley merged 55 commits into
OCA:10.0from
LasLabs:release/10.0/auto_backup
Dec 7, 2016
Merged

[MIG][10.0] auto_backup#614
lasley merged 55 commits into
OCA:10.0from
LasLabs:release/10.0/auto_backup

Conversation

@lasley

@lasley lasley commented Nov 18, 2016

Copy link
Copy Markdown
Contributor
  • Change openerp to odoo
  • Bump version
  • Rename manifest
  • Add pysftp to requirements

@lasley lasley added this to the 10.0 milestone Nov 18, 2016
@lasley
lasley force-pushed the release/10.0/auto_backup branch 2 times, most recently from 8af6290 to e1609a5 Compare November 18, 2016 20:43
Comment thread auto_backup/README.rst

Usage
=====

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ran into an issue where backup execution was dying when running inside of Odoo due to the timeouts configured on the instance. We had to make a small script to run this system outside of the main Odoo instance to circumvent this, which is described in this blog post.

If this is something other people have run into as well, maybe transferring some of that info to this ReadMe would be of use?

@lasley
lasley force-pushed the release/10.0/auto_backup branch 2 times, most recently from baf0f4f to 2430e8f Compare November 18, 2016 21:07
@max3903

max3903 commented Nov 18, 2016

Copy link
Copy Markdown
Member

@lasley Why don't you add a link to your blog post in the module description (know issues section) ?

@lasley

lasley commented Nov 18, 2016

Copy link
Copy Markdown
Contributor Author

Good call, that's exactly where it should go!

@yajo

yajo commented Nov 23, 2016

Copy link
Copy Markdown
Member

Why did we lose commits?

@lasley

lasley commented Nov 23, 2016

Copy link
Copy Markdown
Contributor Author

Squash and merge? The cherry-picked is definitely the commit for this on 9.0

@yajo

yajo commented Nov 24, 2016

Copy link
Copy Markdown
Member

I think the common strategy is to preserve others' commits (except those from transbot, that get squashed) when migrating versions. See https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0

It has the advantage that all previous contributors get subscribed to the PR automatically. They're probably interested.

@lmignon

lmignon commented Nov 24, 2016

Copy link
Copy Markdown
Contributor

@lasley Where is the commit histrory. We must preserve the history! The history is now empty also in 9.0.

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit history from 8.0 must be preserved

Yenthe666 and others added 16 commits November 25, 2016 09:37
Added all the new fields and sentences. This will be the template for
translations.
Full translation of the module to Dutch
Add Chinese translations to the module. Written by talway.
Changed some translations
Thanks to Martin Schmid!
could'nt > couldn't
Flemish translations are identical to Dutch.
Used to open  fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.
[FIX] Flake8
[RM] useless files
[FIX] schedule_backup method
[IMP] IT translation
[IMP] tests
Jairo Llopis and others added 21 commits November 25, 2016 09:37
The filestore is saved in the backup, so if you save the backup in the
filestore, you'd end up with a huge backup that includes itself and the
universe may collapse.
* Add self.ensure_ones
* Add test coverage
* compute_name
* check_folder
* action_sftp_test_connection
* action_backup - sftp
* action_backup_all
* sftp_connection
* filename
* Change openerp to odoo
* Bump version
* Rename manifest
* Add pysftp to requirements
* Add base_setup and update view
@lasley
lasley force-pushed the release/10.0/auto_backup branch from faba732 to d0445a2 Compare November 25, 2016 17:41
@lasley

lasley commented Nov 25, 2016

Copy link
Copy Markdown
Contributor Author

Alright I did the required git-fu for fixing the commit history after merge of #620. Better?

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review only

@lasley
lasley merged commit 144235d into OCA:10.0 Dec 7, 2016
@lasley
lasley deleted the release/10.0/auto_backup branch December 7, 2016 20:54
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants