Skip to content

[MIG] 10.0 super calendar#609

Merged
OCA-git-bot merged 28 commits into
OCA:10.0from
apertoso:10.0_super_calendar
Mar 28, 2022
Merged

[MIG] 10.0 super calendar#609
OCA-git-bot merged 28 commits into
OCA:10.0from
apertoso:10.0_super_calendar

Conversation

@jeanpaulrobineau

Copy link
Copy Markdown

Hello,
I have ported this super calendar for version 10.

Kind regards,
Jean-Paul Robineau

@oca-clabot

Copy link
Copy Markdown

Hey @jeanpaulrobineau, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza mentioned this pull request Nov 16, 2016
63 tasks
@mstuttgart

Copy link
Copy Markdown
Member

LGTM 👍

@jeanpaulrobineau please, fix the Flake8 erros in Travis IC: https://travis-ci.org/OCA/server-tools/jobs/177931147#L322

@eLBati eLBati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeanpaulrobineau
looking at the diff with 8.0 (last release of super_calendar) with
git diff 8.0 apertoso/10.0_super_calendar super_calendar/
I see some commits from 8.0 are missing.
Please follow the procedure described at
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0#technical-method-to-migrate-a-module-from-90-to-100-branch
but replacing 9.0 with 8.0

If you need help, please join #oca channel at freenode.net

@ovnicraft

Copy link
Copy Markdown
Member

@jeanpaulrobineau can you update this PR ?

@JosDeGraeve

Copy link
Copy Markdown
Contributor

Hi,

I worked togheter with Jean-Paul on this. Afaik, these issues have been fixed:

@ovnicraft

Copy link
Copy Markdown
Member

so we wait for @eLBati review

@eLBati eLBati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jeanpaulrobineau

Copy link
Copy Markdown
Author

Hello,

When can this be merged as everything seems ok now?

Kind regards
Jean-Paul Robineau

@JosDeGraeve JosDeGraeve left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been in production for a while now at some of our customers.

@Ehtaga

Ehtaga commented Nov 27, 2017

Copy link
Copy Markdown

@gurneyalex @dreispt @guewen Can we merge this PR?

@elicoidal elicoidal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
Could you please take the opportunity to update standard information such as README, manifest and copyright headers?

@@ -26,7 +26,7 @@
#
##############################################################################

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace with short headers in all py files following: https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py

Comment thread super_calendar/README.rst

Meetings:

.. image:: super_calendar/static/description/meetings.png

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the README file to the newest template available here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst

'version': '10.0.1.0.0',
'category': 'Generic Modules/Others',
'summary': 'This module allows to create configurable calendars.',
'author': ('Agile Business Group, '

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the URL to the repo URL

@@ -46,7 +46,7 @@
],
'demo': [],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty keys

<?xml version="1.0"?>
<openerp>
<odoo>
<data>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove data tag

@ddufresne

Copy link
Copy Markdown

@jeanpaulrobineau are you still working on this? Can you make the few changes asked by @elicoidal so that we can move forward?

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 27, 2022
@dreispt

dreispt commented Mar 28, 2022

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-609-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 562de32 into OCA:10.0 Mar 28, 2022
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at b19f607. Thanks a lot for contributing to OCA. ❤️

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (13.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.