[MIG] 10.0 super calendar#609
Conversation
|
Hey @jeanpaulrobineau, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
LGTM 👍 @jeanpaulrobineau please, fix the Flake8 erros in Travis IC: https://travis-ci.org/OCA/server-tools/jobs/177931147#L322 |
eLBati
left a comment
There was a problem hiding this comment.
Thanks @jeanpaulrobineau
looking at the diff with 8.0 (last release of super_calendar) with
git diff 8.0 apertoso/10.0_super_calendar super_calendar/
I see some commits from 8.0 are missing.
Please follow the procedure described at
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0#technical-method-to-migrate-a-module-from-90-to-100-branch
but replacing 9.0 with 8.0
If you need help, please join #oca channel at freenode.net
|
@jeanpaulrobineau can you update this PR ? |
|
Hi, I worked togheter with Jean-Paul on this. Afaik, these issues have been fixed:
|
|
so we wait for @eLBati review |
|
Hello, When can this be merged as everything seems ok now? Kind regards |
JosDeGraeve
left a comment
There was a problem hiding this comment.
Been in production for a while now at some of our customers.
|
@gurneyalex @dreispt @guewen Can we merge this PR? |
elicoidal
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
Could you please take the opportunity to update standard information such as README, manifest and copyright headers?
| @@ -26,7 +26,7 @@ | |||
| # | |||
| ############################################################################## | |||
|
|
|||
There was a problem hiding this comment.
Could you please replace with short headers in all py files following: https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py
|
|
||
| Meetings: | ||
|
|
||
| .. image:: super_calendar/static/description/meetings.png |
There was a problem hiding this comment.
Could you please update the README file to the newest template available here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
| 'version': '10.0.1.0.0', | ||
| 'category': 'Generic Modules/Others', | ||
| 'summary': 'This module allows to create configurable calendars.', | ||
| 'author': ('Agile Business Group, ' |
| @@ -46,7 +46,7 @@ | |||
| ], | |||
| 'demo': [], | |||
| <?xml version="1.0"?> | ||
| <openerp> | ||
| <odoo> | ||
| <data> |
|
@jeanpaulrobineau are you still working on this? Can you make the few changes asked by @elicoidal so that we can move forward? |
1822b24 to
daef6b6
Compare
…causes an error retrieving the id
daef6b6 to
64e22a5
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at b19f607. Thanks a lot for contributing to OCA. ❤️ |
Syncing from upstream OCA/server-tools (13.0)
Hello,
I have ported this super calendar for version 10.
Kind regards,
Jean-Paul Robineau