Skip to content

[MIG] database_cleanup: Migration to version 10.0#607

Closed
eantones wants to merge 1 commit into
OCA:10.0from
nuobit:10.0-database_cleanup-migration
Closed

[MIG] database_cleanup: Migration to version 10.0#607
eantones wants to merge 1 commit into
OCA:10.0from
nuobit:10.0-database_cleanup-migration

Conversation

@eantones

Copy link
Copy Markdown
Contributor

[MIG] database_cleanup: Migration to version 10.0
Using new base model inheritance

@pedrobaeza pedrobaeza mentioned this pull request Nov 15, 2016
63 tasks
@eantones
eantones force-pushed the 10.0-database_cleanup-migration branch 9 times, most recently from 5e9278c to bf3abc8 Compare November 16, 2016 17:49
@ovnicraft

Copy link
Copy Markdown
Member

All checks passed, need feedback from reviewers

@njeudy njeudy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on real database

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eantones Thank you for this work. (Successfully tested on real database). Can your revert your changes in README.md to resolve the conflicts? Thank you!

Comment thread README.md Outdated
[base_suspend_security](base_suspend_security/) | 10.0.1.0.0 | Suspend security checks for a call
[base_technical_features](base_technical_features/) | 10.0.1.0.0 | Access to technical features without activating debug mode
[base_user_gravatar](base_user_gravatar/) | 10.0.1.0.0 | Synchronize Gravatar Image
[database_cleanup](database_cleanup/) | 10.0.1.0.0 | Database cleanup

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eantones You must to change this section into the README since it's automatically generated by a bot. If you undo your changes here, the conflicts will be resolved

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmignon just done! Thank you!

@njeudy

njeudy commented Jun 14, 2017

Copy link
Copy Markdown

@pedrobaeza @eantones how to help merging this ? I use it in production environnement since 2 month .. need a rebase for merge conflict resolution. thanks for your work.

@eantones
eantones force-pushed the 10.0-database_cleanup-migration branch from ce848c4 to 893dfbc Compare June 14, 2017 13:57
@pedrobaeza

Copy link
Copy Markdown
Member

Well, there are 3 extra commits that doesn't belong to this PR. @eantones please fix that.

@hbrunn hbrunn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some commits from 9.0 missing, compare https://github.com/OCA/server-tools/commits/10.0/database_cleanup and https://github.com/OCA/server-tools/commits/9.0/database_cleanup. (especially the one that adds cleaning up properties and create indexes is something we want)

As you have to redo the branch anyways to get rid of the extraneous commits, I'd suggest to follow https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0, then you get all of this for free

@eantones
eantones force-pushed the 10.0-database_cleanup-migration branch from 893dfbc to 78835f2 Compare June 14, 2017 14:51
Using new base model inheritance.
@eantones
eantones force-pushed the 10.0-database_cleanup-migration branch from 20c6c53 to e7eb2f8 Compare June 21, 2017 12:08
@ecino ecino mentioned this pull request Jul 10, 2017
@pedrobaeza

Copy link
Copy Markdown
Member

#894 also includes 9.0 later commits. Can you please review it?

@yajo yajo added this to the 10.0 milestone Jul 11, 2017
@pedrobaeza

Copy link
Copy Markdown
Member

There was another migration in #894. Have you checked it?

Anyway, this one has Travis failing.

@pedrobaeza pedrobaeza closed this Sep 6, 2017
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (8.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants