Skip to content

[MIG] 9.0 - auditlog#603

Merged
pedrobaeza merged 21 commits into
OCA:9.0from
osiell:9.0-mig-auditlog
Nov 22, 2016
Merged

[MIG] 9.0 - auditlog#603
pedrobaeza merged 21 commits into
OCA:9.0from
osiell:9.0-mig-auditlog

Conversation

@sebalix

@sebalix sebalix commented Nov 13, 2016

Copy link
Copy Markdown
Contributor

Supersedes #454 (no response)

Migration done following the instructions from the wiki + Cherry-picked the commits done by @holdenrehg in #454.

@pedrobaeza

Copy link
Copy Markdown
Member

Thanks for the followup. Please squash all the "OCA Transbot" commits in one, and check Travis status.

@sebalix

sebalix commented Nov 13, 2016

Copy link
Copy Markdown
Contributor Author

Module tested on runbot (full log, fast log, user session, HTTP requests...), works like expected.

Travis fails on the database_cleanup module.

@sebalix

sebalix commented Nov 14, 2016

Copy link
Copy Markdown
Contributor Author

As soon as this module is merged I'll port it on 10.

@sebalix
sebalix force-pushed the 9.0-mig-auditlog branch 4 times, most recently from 7c9ad7e to d2d6dfa Compare November 14, 2016 14:45
@sebalix

sebalix commented Nov 14, 2016

Copy link
Copy Markdown
Contributor Author

@pedrobaeza sorry I didn't see the lint errors, it's fixed now.

I also migrated the last methods to the new API, PR ready for reviews now.

records = self.env[data_model].search(
[('create_date', '<=', fields.Datetime.to_string(deadline))])
nb_records = len(records)
records.unlink()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to launch a real "VACUUM" here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not, but I would prefer in a new PR as it's a new feature.
About the VACUUM, I was thinking that Odoo already performs this operation through ir.autovacuum https://github.com/odoo/odoo/blob/9.0/openerp/addons/base/ir/ir_autovacuum.py but it's not a real VACUUM neither.

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little comment, but overall 👍

@lasley lasley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sebalix - I agree with your eval that adding the actual vacuum should be a separate PR, which would also allow for easy backports

@lasley

lasley commented Nov 22, 2016

Copy link
Copy Markdown
Contributor

Travis is 🔴 but not on your module and I think it's been resolved already. Restarting build; this can be merged if 🍏

@lasley lasley added this to the 9.0 milestone Nov 22, 2016
@sebalix

sebalix commented Nov 22, 2016

Copy link
Copy Markdown
Contributor Author

PR rebased but it's failing on database_cleanup.

@pedrobaeza

Copy link
Copy Markdown
Member

This PR is supposed to fix it: #612

sebalix and others added 10 commits November 22, 2016 11:53
* [IMP] index the columns we'll be searching for for every request

* [FIX] singleton error if we saved the current session two times
- Update documentation to point to the new auditlog menu locations. These were changed because the 8.0 version was referencing menus that do not exist in 9.0
- Change version from 8.0.X.Y.Z to 9.0.1.0.0
- Make the module installable again
- Remove an unused parameter from pre-migration.py for versioning
- Fix typos and remove commented out blocks of code that were irrelevant
…ields

These were updated to follow OCA conventions.

- License set to AGPL-3
- Images set to empty array
@sebalix

sebalix commented Nov 22, 2016

Copy link
Copy Markdown
Contributor Author

Rebased to include #612 , Travis is now green

@pedrobaeza

Copy link
Copy Markdown
Member

OK, merging. Thanks for the PR.

@pedrobaeza
pedrobaeza merged commit eac8c06 into OCA:9.0 Nov 22, 2016
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (7.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants