Migrating MassEditing to v10 by JayVora-SerpentCS · Pull Request #598 · OCA/server-tools

JayVora-SerpentCS · 2016-11-10T15:13:50Z

No description provided.

nhomar · 2016-11-11T06:46:52Z

One quick quiestion.

I think the button in the screen that create the action to comply with the >v8.0 usability standard due to the fact that is an "action" button and not a "link" buttton should be in the top of the screen.

I know this is a silly question but I personally think we all will be more happy if we migrate to 10.0 with this little change..

Can You? or do you prefer I make a separate PR?

jgrandguillaume

Hi @JayVora-SerpentCS

Thanks for this great module !

Tested and works well 👍

Regards,

Joël

atchuthan · 2016-11-11T15:16:15Z

Found a strange bug when I tried to test the functionality in Runbot

URL: http://3271979-598-6ab5a8.runbot1.odoo-community.org/

Partner Mass editing

Mass editing window after selecting 2 partners (ASUSTeK/Test1 & ASUSTeK/Test2)

Mass editing window after selecting all partners

pedrobaeza · 2016-11-11T16:50:28Z

@JayVora-SerpentCS, thanks for maintaining this module. Please follow full 10.0 migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0#tasks-to-do-in-the-migration and take care about the comments.

You also need to bring the latest changes of the 9.0 branch. For example 65a1579. This is done with https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0#technical-method-to-migrate-a-module-from-90-to-100-branch

JayVora-SerpentCS · 2016-12-09T13:54:35Z

@pedrobaeza how to bring 65a1579?

pedrobaeza · 2016-12-09T15:58:14Z

Do:

git remote update
git cherry-pick 65a1579

njeudy

Tested and code review

👍

antoniocanovas

LGTM, Tested on runbot.

pedrobaeza · 2016-12-10T10:53:00Z

The missing commits are still not brought and there's a comment unattended.

JayVora-SerpentCS · 2016-12-10T12:05:45Z

Agreed, working on them soon.
Thanks.

ovnicraft · 2016-12-28T22:48:10Z

Hi @JayVora-SerpentCS any updates for this ? is ready to merge ? @pedrobaeza

JayVora-SerpentCS · 2016-12-29T06:51:34Z

Cherrypicked Pedro's commit. now working on the other 2 comments.

JayVora-SerpentCS · 2016-12-29T10:45:16Z

@nhomar covered.

@atchuthan I tried various scenarios, but did not manage to reproduce. Would you please retry?
Thanks.

ovnicraft · 2016-12-29T13:49:28Z

Tested on runbot and working ok 👍
I cant reproduce @atchuthan bug reported in partners.

ovnicraft · 2017-01-10T17:42:36Z

There is no report to reproduce the bug mentioned by @atchuthan, IMO this is ready to merge.

JonathanNEMRY

Hi! Great work! I just made a PR on your branch to add setuptools. Otherwise 👍
JayVora-SerpentCS#1

JonathanNEMRY

👍

pedrobaeza · 2017-01-17T12:57:54Z

Squashing and merging. Thanks for the work.

pedrobaeza · 2017-01-17T13:25:18Z

@JayVora-SerpentCS, I'm missing these two important pieces for improving the module that has been done in v8:

Can you please adapt the code for this version?

pedrobaeza

Due to above comment

JayVora-SerpentCS · 2017-01-18T08:52:54Z

Processed.

atchuthan

@JayVora-SerpentCS
Sorry for the late follow-up. I couldn't reproduce the error in latest runbot. So, 👍 my vote

pedrobaeza · 2017-02-14T08:18:56Z

This is not cherry-picking, Jay. A cherry-pick is that you bring the commits as is, not integrating them in another commit with you as the author of the full diff:

A correct cherry-pick would show in the commit list both commits with the corresponding authors, something like:

mourad-ehm · 2017-02-14T08:32:01Z

Code review 👍

LoisRForgeFlow

This error pops when trying to add items to a new mass.object record (testing on runbot):

Also, please attend runbot warning: WARNING openerp_test odoo.fields: Field mass.object.name: parameter 'select' is no longer supported; use 'index' instead.

@StefanRijnhart

As commented by @StefanRijnhart, this is no longer needed after 4442424: > This hack in the model's search method allowed for a domain containing a stringified list of ids. It has been obsolete since 4442424, and can safely be removed (i.e. remove the whole file). Closes OCA#638.

…2m field.

JayVora-SerpentCS · 2017-02-15T08:00:22Z

@pedrobaeza You are a nice teacher along with Google! I learned well now the cherry-picking. Earlier commits were squashed and hence it would reflect we ate them, which we actually did not.
I rebased the PR nicely now.
@lreficent Sorry I do not see a reason to face the error. Any detailed traceback possible?
Thanks.

AaronHForgeFlow

When creating a mass editing record on runbot I'm getting an error:

LoisRForgeFlow · 2017-02-15T09:11:26Z

@JayVora-SerpentCS I get the error when trying to create a Mass Editing record as usual and trying to add the fields. I have just tested on local right now, same error raises. Aren't you getting the error? Maybe it is my fault but I think it is worth that you test it at least functionally in a moment to test whether it pops for you or not. Really appreciate the effort, thanks!

JayVora-SerpentCS · 2017-02-15T09:40:17Z

Will check definitely soon and fix if such happens.

JayVora-SerpentCS · 2017-02-16T06:17:13Z

@aheficent @lreficent True that, made sure no loop hole stays now, edited the domain and fixed.
Thanks.

AaronHForgeFlow · 2017-02-16T08:34:01Z

+
+    @api.model
+    def search(self, args, offset=0, limit=0, order=None, count=False):
+        print args


I guess this is here for debugging and you will remove it. Also, this is causing travis to fail.

The runbot is working now. Thanks.

For sure, thanks, managed. Had pushed in a hurry :)

AaronHForgeFlow

👍 Thanks

LoisRForgeFlow

Works fine now. Thank you!

pedrobaeza · 2017-02-16T15:15:57Z

@JayVora-SerpentCS, if you want to avoid the forgotten print and pylint/flake8 errors locally, you can install the GIT pre-commit we prepare in MQT: https://github.com/OCA/maintainer-quality-tools/tree/master/git

JayVora-SerpentCS · 2017-02-17T08:49:14Z

@pedrobaeza I am using pycharm with pep8 and pyflakes extension already.
I will install the precommit too. Thanks.

pedrobaeza

Well, finally the history is still no clean (as the other commits don't contain diff), but I don't want to block more time, so I finally squash.

Syncing from upstream OCA/server-tools (13.0)

JayVora-SerpentCS changed the title ~~Mig to v10~~ Migrating MassEditing to v10 Nov 10, 2016

jgrandguillaume approved these changes Nov 11, 2016

View reviewed changes

jgrandguillaume added the needs review label Nov 11, 2016

pedrobaeza mentioned this pull request Nov 11, 2016

Migration to version 10.0 #565

Closed

63 tasks

njeudy approved these changes Dec 9, 2016

View reviewed changes

antoniocanovas approved these changes Dec 10, 2016

View reviewed changes

pedrobaeza mentioned this pull request Dec 19, 2016

Enable installation for mass_editing #654

Closed

pedrobaeza mentioned this pull request Jan 16, 2017

[MIG][mass_editing] from 9.0 to 10.0 #702

Closed

JonathanNEMRY suggested changes Jan 16, 2017

View reviewed changes

JonathanNEMRY approved these changes Jan 17, 2017

View reviewed changes

pedrobaeza force-pushed the mass_editing10 branch from 3f25741 to f073f72 Compare January 17, 2017 13:23

pedrobaeza requested changes Jan 17, 2017

View reviewed changes

JayVora-SerpentCS force-pushed the mass_editing10 branch from f073f72 to 755c793 Compare January 18, 2017 02:25

atchuthan approved these changes Jan 18, 2017

View reviewed changes

JayVora-SerpentCS force-pushed the mass_editing10 branch from e9e7df1 to d600eb7 Compare January 19, 2017 06:40

LoisRForgeFlow requested changes Feb 14, 2017

View reviewed changes

[MIG] Migrated the v10 for mass_editing

35e0e85

JayVora-SerpentCS force-pushed the mass_editing10 branch from 6c7e240 to 35e0e85 Compare February 15, 2017 07:43

hpestano and others added 2 commits February 15, 2017 13:20

[ENH] Transformed mass.object's model_list char field into a proper m…

6c00dc2

…2m field.

JayVora-SerpentCS force-pushed the mass_editing10 branch from 7adaac3 to 6c00dc2 Compare February 15, 2017 07:57

AaronHForgeFlow suggested changes Feb 15, 2017

View reviewed changes

[FIX] Domain fixture

a41374f

AaronHForgeFlow reviewed Feb 16, 2017

View reviewed changes

Update mass_object.py

1ca2d42

AaronHForgeFlow approved these changes Feb 16, 2017

View reviewed changes

LoisRForgeFlow approved these changes Feb 16, 2017

View reviewed changes

pedrobaeza approved these changes Feb 20, 2017

View reviewed changes

pedrobaeza merged commit 2d47eb4 into OCA:10.0 Feb 20, 2017

mstuttgart pushed a commit to multidadosti-erp/server-tools that referenced this pull request Apr 20, 2017

[MIG] mass_editing: Migration to v10 (OCA#598)

cae0d1a

JayVora-SerpentCS mentioned this pull request May 7, 2017

[10.0][FIX] backport of SerpentCS mass_editing v10 port #820

Merged

jnegrete pushed a commit to AlceConsorcio/server-tools that referenced this pull request Nov 11, 2017

[MIG] mass_editing: Migration to v10 (OCA#598)

4b7f3c5

ljimenezsidoo pushed a commit to PESOL/server-tools that referenced this pull request Mar 28, 2018

[MIG] mass_editing: Migration to v10 (OCA#598)

51dba34

holdenrehg pushed a commit to holdenrehg-forks/server-tools that referenced this pull request Aug 21, 2018

[MIG] mass_editing: Migration to v10 (OCA#598)

1ffb7da

holdenrehg pushed a commit to holdenrehg-forks/server-tools that referenced this pull request Aug 21, 2018

[MIG] mass_editing: Migration to v10 (OCA#598)

8561dc3

holdenrehg pushed a commit to holdenrehg-forks/server-tools that referenced this pull request Aug 21, 2018

[MIG] mass_editing: Migration to v10 (OCA#598)

02c09b6

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#598 from OCA/13.0

e1828e9

Syncing from upstream OCA/server-tools (13.0)

Uh oh!

Uh oh!

Conversation

JayVora-SerpentCS commented Nov 10, 2016

Uh oh!

nhomar commented Nov 11, 2016

Uh oh!

jgrandguillaume left a comment

Choose a reason for hiding this comment

Uh oh!

atchuthan commented Nov 11, 2016

Uh oh!

pedrobaeza commented Nov 11, 2016

Uh oh!

JayVora-SerpentCS commented Dec 9, 2016

Uh oh!

pedrobaeza commented Dec 9, 2016

Uh oh!

njeudy left a comment

Choose a reason for hiding this comment

Uh oh!

antoniocanovas left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Dec 10, 2016

Uh oh!

JayVora-SerpentCS commented Dec 10, 2016

Uh oh!

ovnicraft commented Dec 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JayVora-SerpentCS commented Dec 29, 2016

Uh oh!

JayVora-SerpentCS commented Dec 29, 2016

Uh oh!

ovnicraft commented Dec 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovnicraft commented Jan 10, 2017

Uh oh!

JonathanNEMRY left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanNEMRY left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Jan 17, 2017

Uh oh!

pedrobaeza commented Jan 17, 2017

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

JayVora-SerpentCS commented Jan 18, 2017

Uh oh!

atchuthan left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Feb 14, 2017

Uh oh!

mourad-ehm commented Feb 14, 2017

Uh oh!

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

JayVora-SerpentCS commented Feb 15, 2017

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

LoisRForgeFlow commented Feb 15, 2017

Uh oh!

JayVora-SerpentCS commented Feb 15, 2017

Uh oh!

JayVora-SerpentCS commented Feb 16, 2017

Uh oh!

AaronHForgeFlow Feb 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

ovnicraft commented Dec 28, 2016 •

edited

Loading

ovnicraft commented Dec 29, 2016 •

edited

Loading

JonathanNEMRY left a comment •

edited

Loading

AaronHForgeFlow Feb 16, 2017 •

edited

Loading