Skip to content

[10.0] Migrate base_optional_quick_create to v10#597

Merged
sbidoul merged 2 commits into
OCA:10.0from
akretion:10-mig-quick_create
Apr 23, 2017
Merged

[10.0] Migrate base_optional_quick_create to v10#597
sbidoul merged 2 commits into
OCA:10.0from
akretion:10-mig-quick_create

Conversation

@alexis-via

Copy link
Copy Markdown
Contributor

No description provided.

@jgrandguillaume jgrandguillaume left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexis-via

Thanks for the work.

Works well ! 👍

Regards,

Joël

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + functionnal 👍

@atchuthan atchuthan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runbot 👍

@pedrobaeza

Copy link
Copy Markdown
Member

You should use the new base model inheritance instead of monkey-patching.

@pedrobaeza

Copy link
Copy Markdown
Member

Why runbot fails? I have launched a rebuild to see

@espo-tony

espo-tony commented Mar 17, 2017

Copy link
Copy Markdown

👍

I guess the runbot fails because of:

2017-03-17 03:14:54,259 207 WARNING openerp_test odoo.fields: Field date.range.type.company_id: parameter 'select' is no longer supported; use 'index' instead.
2017-03-17 03:14:54,276 207 WARNING openerp_test odoo.fields: Field date.range.company_id: parameter 'select' is no longer supported; use 'index' instead.
2017-03-17 03:14:54,276 207 WARNING openerp_test odoo.fields: Field date.range.type_id: parameter 'select' is no longer supported; use 'index' instead.

Models date.range.type and date.range are defined in the module date_range, and in the latest version they use the correct parameter 'index' instead of 'select'. The author of the PR could need to update his local branch (the one from which this PR was generated) as it keeps the old version of the module and cause the warnings into the runbot.

Anyway surely is not related to this migration, which looks to be working.

@sbidoul
sbidoul merged commit 0830f84 into OCA:10.0 Apr 23, 2017
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants