Migration of base_suspend_security to 10.0#586
Conversation
…ty method is available in tests without calling the _register_hook Indeed tests are run after the call to _setup_complete and before the call to _register_hook
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
as soon as travis is happy: https://travis-ci.org/OCA/server-tools/jobs/170163534#L317
444bfb5 to
43e5d0c
Compare
|
Thanks @hbrunn 😄 |
lasley
left a comment
lasley
left a comment
There was a problem hiding this comment.
Thanks @adrienpeiffer - minor comment but otherwise 👍
| "name": "Suspend security", | ||
| "version": "9.0.1.0.0", | ||
| "version": "10.0.1.0.0", | ||
| "author": "Therp BV", |
There was a problem hiding this comment.
Missing , Odoo Community Association (OCA)
|
Thanks Dave ! |
|
Runbot error is due to odoo/odoo#14036, so I merge this as @lasley's comment is attended. |
| @tools.ormcache_context('uid', 'model', 'mode', 'raise_exception', | ||
| @api.model | ||
| @tools.ormcache_context('self._uid', 'model', 'mode', 'raise_exception', | ||
| keys=('lang',)) |
There was a problem hiding this comment.
@hbrunn Why is the 'lang' value into the context a discriminant value to use as cache key?
There was a problem hiding this comment.
@lmignon AFAIK, this is the same as the standard method definition
There was a problem hiding this comment.
@adrienpeiffer that's a good reason, but not a good explanation ;-) - I believe https://github.com/OCA/OCB/blob/10.0/odoo/addons/base/ir/ir_model.py#L828-L831 phrases it sufficiently. Given it's still only the returns decorator which is propagated in inheritance (https://github.com/OCA/OCB/blob/10.0/odoo/api.py#L99, https://github.com/OCA/OCB/blob/10.0/odoo/api.py#L127, https://github.com/OCA/OCB/blob/10.0/odoo/api.py#L77), I think it's the right thing to do to copy the original, even though it doesn't have an effect currently save for being slightly less efficient in cases of switching language
Syncing from upstream OCA/server-tools (11.0)
5 participants
No description provided.