Skip to content

[MIG][10.0] base_external_dbsource - #578

Merged
max3903 merged 4 commits into
OCA:10.0from
maxodoo:adapted-to-10.0
Nov 25, 2016
Merged

[MIG][10.0] base_external_dbsource#578
max3903 merged 4 commits into
OCA:10.0from
maxodoo:adapted-to-10.0

Conversation

@jlzhou

@jlzhou jlzhou commented Oct 19, 2016

Copy link
Copy Markdown

Adapted to 10.0
#565

@pedrobaeza pedrobaeza mentioned this pull request Oct 19, 2016
63 tasks
@pedrobaeza

Copy link
Copy Markdown
Member

Annotated in the issue

@jlzhou

jlzhou commented Oct 19, 2016

Copy link
Copy Markdown
Author

Can anyone help to indicate what's wrong here?

Some checks were not successful
1 failing and 1 successful checks

@pedrobaeza

Copy link
Copy Markdown
Member

There are lint errors:

https://travis-ci.org/OCA/server-tools/jobs/168909969

@lasley lasley added this to the 10.0 milestone Oct 23, 2016
@jlzhou

jlzhou commented Nov 5, 2016

Copy link
Copy Markdown
Author

@pedrobaeza Please advise where to see the detailed failure information, thanks!
By clicking ci/runbot's details link on the right below, I could get nothing.

@pedrobaeza

Copy link
Copy Markdown
Member

Pressing the gear button and clicking on "Full all logs", you can see the error: https://runbot2.odoo-community.org/runbot/static/build/3271468-578-10ad16/logs/job_20_test_all.txt

But it's not your fault. It's something with Odoo. See odoo/odoo#14057

@ghost ghost mentioned this pull request Nov 7, 2016
@jlzhou

jlzhou commented Nov 9, 2016

Copy link
Copy Markdown
Author

What should I do next? The process of PR is too slow.
@pedrobaeza

@pedrobaeza

Copy link
Copy Markdown
Member

If people are not interested in this module, they're not going to review it. You can review other PRs of the same topic/repository and ask for a review here in exchange. You can also enroll other colleagues to review your work.

@lnkdel

lnkdel commented Nov 10, 2016

Copy link
Copy Markdown

I think this PR is good. My PR #596 depends on it.

@mstuttgart

Copy link
Copy Markdown
Member

LGTM 👍

@aldo774

aldo774 commented Nov 24, 2016

Copy link
Copy Markdown
Member

LGTM 👍

@max3903

max3903 commented Nov 25, 2016

Copy link
Copy Markdown
Member

👍

@max3903
max3903 merged commit 33e3228 into OCA:10.0 Nov 25, 2016
flachica pushed a commit to flachica/server-tools that referenced this pull request Aug 2, 2022
flachica pushed a commit to flachica/server-tools that referenced this pull request Aug 13, 2022
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants