[FIX][base_import_match] Avoid UnicodeEncodeError. - #544
Merged
Conversation
Member
|
👍 |
Member
Author
|
Travis ❌ unrelated |
Contributor
|
FYI We have a open discussion of this matter OCA/pylint-odoo#65 |
Contributor
|
Ahhh good ol' unicode 👍 |
Contributor
|
👍 (just small comments) |
| s.name = u"{}: {}".format( | ||
| s.model_id.display_name, | ||
| " + ".join( | ||
| u" + ".join( |
Contributor
There was a problem hiding this comment.
This u is not required.
Just in the format sentence is required.
Member
Author
|
Trying different (I think it is better) approach. |
| s.field_ids.mapped( | ||
| lambda r: ( | ||
| str(r.field_id.name) + | ||
| unicode(r.field_id.name) + |
Contributor
There was a problem hiding this comment.
odoo returns a unicode string here then we don't need a unicode(string_unicode) again.
The problem is use "{}".format() instead of u"{}".format() (Notice the u prefix)
Contributor
There was a problem hiding this comment.
u'%s' % u'á' # without error
'%s' % u'á' # without error
u'{}'.format(u'á') # without error
'{}'.format(u'á') # UnicodeEncodeError
Member
Author
There was a problem hiding this comment.
I think you don't get the point. I have to use unicode because otherwise if r.field_id.name is False this would blow.
Contributor
There was a problem hiding this comment.
I mean,
odoo returns a unicode string then we don't need a
unicode(string_unicode)again...
for all strings returned.
We could use string_unicode or 'None' just for None cases avoiding additional re-processing of unicode method.
Contributor
There was a problem hiding this comment.
Agreed, method calls in Python are more expensive than boolean evaluations - so the proposed my_field and u'{}'.format(my_field) or my_field would be ideal even though more code. Although I bet there's a cleaner fallback strategy too...
Member
Author
There was a problem hiding this comment.
I double-checked, and after all name and field_id are required, so no chance of getting False. I'll just drop casting.
yajo
force-pushed
the
8.0-base_import_match-fix_ascii
branch
from
September 20, 2016 09:29
ce7b13e to
dec4c3f
Compare
When the model or field you chose was translated and had some non-ascii character, you got an error like this: `UnicodeEncodeError: 'ascii' codec can't encode character u'\xed' in position 15: ordinal not in range(128)`. Now, using unicode strings, that won't happen again.
yajo
force-pushed
the
8.0-base_import_match-fix_ascii
branch
from
September 20, 2016 09:33
dec4c3f to
0170f56
Compare
Member
Author
|
Finally 💚 ! |
Contributor
|
👍 thanks |
cubells
pushed a commit
to Tecnativa/server-tools
that referenced
this pull request
Dec 15, 2016
* Fix wrong README format. * [FIX][base_import_match] Avoid UnicodeEncodeError. When the model or field you chose was translated and had some non-ascii character, you got an error like this: `UnicodeEncodeError: 'ascii' codec can't encode character u'\xed' in position 15: ordinal not in range(128)`. Now, using unicode strings, that won't happen again. * Do not require a hidden field. * Further unicode protection, add ondelete clause.
cubells
pushed a commit
to Tecnativa/server-tools
that referenced
this pull request
Dec 15, 2016
* Fix wrong README format. * [FIX][base_import_match] Avoid UnicodeEncodeError. When the model or field you chose was translated and had some non-ascii character, you got an error like this: `UnicodeEncodeError: 'ascii' codec can't encode character u'\xed' in position 15: ordinal not in range(128)`. Now, using unicode strings, that won't happen again. * Do not require a hidden field. * Further unicode protection, add ondelete clause.
nicomacr
pushed a commit
to adhoc-dev/server-tools
that referenced
this pull request
Dec 16, 2016
* Fix wrong README format. * [FIX][base_import_match] Avoid UnicodeEncodeError. When the model or field you chose was translated and had some non-ascii character, you got an error like this: `UnicodeEncodeError: 'ascii' codec can't encode character u'\xed' in position 15: ordinal not in range(128)`. Now, using unicode strings, that won't happen again. * Do not require a hidden field. * Further unicode protection, add ondelete clause.
pedrobaeza
pushed a commit
to Tecnativa/server-tools
that referenced
this pull request
Dec 17, 2016
* Fix wrong README format. * [FIX][base_import_match] Avoid UnicodeEncodeError. When the model or field you chose was translated and had some non-ascii character, you got an error like this: `UnicodeEncodeError: 'ascii' codec can't encode character u'\xed' in position 15: ordinal not in range(128)`. Now, using unicode strings, that won't happen again. * Do not require a hidden field. * Further unicode protection, add ondelete clause.
yajo
added a commit
to Tecnativa/server-tools
that referenced
this pull request
Jun 22, 2017
* Fix wrong README format. * [FIX][base_import_match] Avoid UnicodeEncodeError. When the model or field you chose was translated and had some non-ascii character, you got an error like this: `UnicodeEncodeError: 'ascii' codec can't encode character u'\xed' in position 15: ordinal not in range(128)`. Now, using unicode strings, that won't happen again. * Do not require a hidden field. * Further unicode protection, add ondelete clause.
pedrobaeza
pushed a commit
to Tecnativa/server-tools
that referenced
this pull request
Aug 16, 2017
* Fix wrong README format. * [FIX][base_import_match] Avoid UnicodeEncodeError. When the model or field you chose was translated and had some non-ascii character, you got an error like this: `UnicodeEncodeError: 'ascii' codec can't encode character u'\xed' in position 15: ordinal not in range(128)`. Now, using unicode strings, that won't happen again. * Do not require a hidden field. * Further unicode protection, add ondelete clause.
lasley
pushed a commit
to LasLabs/server-tools
that referenced
this pull request
Aug 29, 2017
* Fix wrong README format. * [FIX][base_import_match] Avoid UnicodeEncodeError. When the model or field you chose was translated and had some non-ascii character, you got an error like this: `UnicodeEncodeError: 'ascii' codec can't encode character u'\xed' in position 15: ordinal not in range(128)`. Now, using unicode strings, that won't happen again. * Do not require a hidden field. * Further unicode protection, add ondelete clause.
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (12.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the model or field you chose was translated and had some non-ascii
character, you got an error like this:
UnicodeEncodeError: 'ascii' codec can't encode character u'\xed' in position 15: ordinal not in range(128).Now, using unicode strings, that won't happen again.
Also fix wrong README format.
@Tecnativa