[8.0] database_cleanup fix tests#512
Merged
Merged
Conversation
This reverts commit e6ebcb8.
which has weird side effects during testing. Take care database_cleanup's tests don't mess up the following tests
Member
|
👍 (and very favorable to fast tracking) |
Member
|
👍 |
Member
|
@hbrunn we are still experiencing semi random build failures on the 8.0 branch, since this PR was merged:
Could it be that your fix missed something? |
Member
|
I confirm this issue, got these Travis heisenbugs on this other PR of my own https://travis-ci.org/akretion/server-tools/jobs/152596166 |
Member
Author
|
can you comment out https://github.com/hbrunn/server-tools/blob/53e43317b6ade35477ed5dff9c8e43d6aef2fbb9/database_cleanup/tests/test_database_cleanup.py#L59-L72 and see what happens then? |
Member
|
Cool trick, again. |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (9.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf #509