Skip to content

[ADD] point_of_sale_enterprise_remove - #497

Closed
woodbrettm wants to merge 1 commit into
OCA:9.0from
LasLabs:feature/9.0/add-point_of_sale_enterprise_remove
Closed

[ADD] point_of_sale_enterprise_remove#497
woodbrettm wants to merge 1 commit into
OCA:9.0from
LasLabs:feature/9.0/add-point_of_sale_enterprise_remove

Conversation

@woodbrettm

Copy link
Copy Markdown

This module removes any settings marked as enterprise from the point_of_sale res_config view.

Cheers,
Brett

@lasley

@lasley

lasley commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

👍

<xpath expr="//label[@for='module_pos_loyalty']" position="attributes">
<attribute name="invisible">True</attribute>
</xpath>
<xpath expr="//div[field[@name='module_pos_loyalty']]/.." position="attributes">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnot there the restaurant as well?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm I don't see an option for that in the res_config view :. Only the loyalty option.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I thought pos_restaurant was in enterprise :/
👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even know it existed until now, so I'm admittedly glad you made the comment 😄

@pedrobaeza

Copy link
Copy Markdown
Member

Remove the SVG file squashing the commit

@woodbrettm
woodbrettm force-pushed the feature/9.0/add-point_of_sale_enterprise_remove branch from 8c41687 to e62e580 Compare August 5, 2016 12:48
@gurneyalex

Copy link
Copy Markdown
Member

@BMW95 the 9.0 travis build was recently fixed, can you rebase your PR?

@gurneyalex gurneyalex added this to the 9.0 milestone Aug 9, 2016
…emove to hide relevant enterprise settings.
@woodbrettm
woodbrettm force-pushed the feature/9.0/add-point_of_sale_enterprise_remove branch from e62e580 to 2d2eff4 Compare August 11, 2016 23:29
@woodbrettm

Copy link
Copy Markdown
Author

@pedrobaeza @gurneyalex The 3 PR's have been rebased and are ready to go. The only thing is that in this pr, and crm, the test coverage has been decreased by 0.2% for some reason. The website pr seems good, but a little puzzling why decrease of 0.2% for the other two. Will that be an issue?

@gurneyalex

Copy link
Copy Markdown
Member

👍

@woodbrettm

Copy link
Copy Markdown
Author

As per #499 this pr will be closed.

@woodbrettm woodbrettm closed this Aug 17, 2016
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (11.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants