Skip to content

[ADD] website_enterprise_remove - #496

Closed
woodbrettm wants to merge 1 commit into
OCA:9.0from
LasLabs:feature/9.0/add-website_enterprise_remove
Closed

[ADD] website_enterprise_remove#496
woodbrettm wants to merge 1 commit into
OCA:9.0from
LasLabs:feature/9.0/add-website_enterprise_remove

Conversation

@woodbrettm

Copy link
Copy Markdown

This module removes any settings marked as enterprise from the website res_config view.

Cheers,
Brett

@lasley

@lasley

lasley commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

👍

position="attributes">
<attribute name="invisible">True</attribute>
</xpath>
<xpath expr="//div[field[@name='module_website_form_editor']]/.." position="attributes">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about A/B versioning?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the config structure:
res_config

Instead of targeting each separate div containing each field with its corresponding label, I opted to target the parent div if all the settings were marked as enterprise in that group. The module_website_form_editor is the first div group item in the group, so I just used that to target the parent div (the div that's sibling to label string="Extra Features"), which if set to invisible, covers the a/b test setting as well.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crystal clear. Thanks

@pedrobaeza

Copy link
Copy Markdown
Member

Remove the SVG file squashing the commit.

@woodbrettm
woodbrettm force-pushed the feature/9.0/add-website_enterprise_remove branch from 18bb668 to b52716b Compare August 5, 2016 12:50
@gurneyalex gurneyalex added this to the 9.0 milestone Aug 9, 2016
@gurneyalex

Copy link
Copy Markdown
Member

@BMW95 the 9.0 travis build was recently fixed, can you rebase your PR?

@woodbrettm

Copy link
Copy Markdown
Author

@gurneyalex sure thing. Sorry for the late reply, having some issues with my machine I'll get the 3 pr's rebased in a bit.

@woodbrettm
woodbrettm force-pushed the feature/9.0/add-website_enterprise_remove branch from b52716b to 8150c48 Compare August 11, 2016 23:27
@woodbrettm

Copy link
Copy Markdown
Author

As per #499 this pr will be closed.

@woodbrettm woodbrettm closed this Aug 17, 2016
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants