Skip to content

[18.0][FIX] base_exception: enforce blocking check in wizard#3679

Open
collinskipkorir wants to merge 1 commit into
OCA:18.0from
collinskipkorir:18.0-fix-base-exception-blocking-wizard
Open

[18.0][FIX] base_exception: enforce blocking check in wizard#3679
collinskipkorir wants to merge 1 commit into
OCA:18.0from
collinskipkorir:18.0-fix-base-exception-blocking-wizard

Conversation

@collinskipkorir

@collinskipkorir collinskipkorir commented Jul 18, 2026

Copy link
Copy Markdown

Closes #3667

Problem

The confirmation wizard could allow blocking exceptions to be ignored when a downstream exception module set ignore_exception = True directly.

That write can remove the linked exceptions before action_ignore_exceptions() validates whether any exception is blocking.

Solution

Validate the wizard's original exception list before allowing exceptions to be ignored. The wizard then calls action_ignore_exceptions() to follow the standard ignore workflow.

Testing

  • Added regression coverage for a downstream wizard that writes ignore_exception directly.
  • The complete base_exception test suite passes.
  • Pre-commit, Ruff, Ruff Format, and Pylint checks pass.
  • Manually tested using purchase_exception.
  • Confirmed that a blocking purchase exception raises an error and cannot be ignore

I confirm I have read the DCO (https://github.com/OCA/oca-addons-repo-template/blob/master/CONTRIBUTING.md) and signed it off.

@thomaspaulb help me review this

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @sebastienbeau, @hparfr,
some modules you are maintaining are being modified, check this out!

@collinskipkorir collinskipkorir left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need a review to this

@collinskipkorir

Copy link
Copy Markdown
Author

hi
@sebastienbeau i need a review on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[base_exception] wizard ignores is_blocking when "Ignore Exceptions" is checked

2 participants