[18.0][FIX] base_exception: enforce blocking check in wizard#3679
Open
collinskipkorir wants to merge 1 commit into
Open
[18.0][FIX] base_exception: enforce blocking check in wizard#3679collinskipkorir wants to merge 1 commit into
collinskipkorir wants to merge 1 commit into
Conversation
Contributor
|
Hi @sebastienbeau, @hparfr, |
collinskipkorir
commented
Jul 20, 2026
collinskipkorir
left a comment
Author
There was a problem hiding this comment.
I need a review to this
Author
|
hi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3667
Problem
The confirmation wizard could allow blocking exceptions to be ignored when a downstream exception module set
ignore_exception = Truedirectly.That write can remove the linked exceptions before
action_ignore_exceptions()validates whether any exception is blocking.Solution
Validate the wizard's original exception list before allowing exceptions to be ignored. The wizard then calls
action_ignore_exceptions()to follow the standard ignore workflow.Testing
ignore_exceptiondirectly.base_exceptiontest suite passes.purchase_exception.I confirm I have read the DCO (https://github.com/OCA/oca-addons-repo-template/blob/master/CONTRIBUTING.md) and signed it off.
@thomaspaulb help me review this