Skip to content

[19.0][MIG] auto_backup: Migration to 19.0#3592

Merged
OCA-git-bot merged 45 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-auto_backup
Jul 17, 2026
Merged

[19.0][MIG] auto_backup: Migration to 19.0#3592
OCA-git-bot merged 45 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-auto_backup

Conversation

@BhaveshHeliconia

@BhaveshHeliconia BhaveshHeliconia commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@stferraro stferraro left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mmircoli-nexapp

Copy link
Copy Markdown

can you solve the conflct?

@OCA-git-bot OCA-git-bot added series:19.0 mod:auto_backup Module auto_backup mod:onchange_helper Module onchange_helper labels Jul 8, 2026
@BhaveshHeliconia

Copy link
Copy Markdown
Contributor Author

@mmircoli-nexapp the conflicts have been resolved. Thanks!

@mmircoli-nexapp

Copy link
Copy Markdown

@mmircoli-nexapp the conflicts have been resolved. Thanks!

thanks to you

@mmircoli-nexapp mmircoli-nexapp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Yenthe666 and others added 16 commits July 17, 2026 12:42
Added all the new fields and sentences. This will be the template for
translations.
Used to open  fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.
- Follow template README.
- Remove HTML README.
- Move models to models folder.
- Model and view file names follow guidelines.
- Unused methods cleanup.
- Remove unneeded `.pot` file.
- Fix permissons.
- Follow PEP8 in names everywhere.
- Set more descriptive field names.
- Disable backups for other databases, for security.
- Remove db name from generated file, for easier cleanup.
- EAFP logic everywhere.
- More descriptive name.
- Data files moved to YAML, with cleaner ir.cron record creation.
- Add permissions for db.backup model.
- Icons.
- Update tests with new format.
- Storage method is a selectable, for easier extensibility.
- Instead of custom mailing, it just has a mail thread where you can subscribe.
- Should fix almost all comments in OCA#203.
- Reduce headers.

This respects the upstream license choice (GPL/AGPL) but reduces
verbosity.

It would be ideal to have everything under AGPL though.
* Add self.ensure_ones
* Add test coverage
* [10.0][auto_backup] Menu entry moved

* Update version in manifest
Currently translated at 58.2% (32 of 55 strings)

Translation: server-tools-11.0/server-tools-11.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-auto_backup/nl/
primes2h and others added 19 commits July 17, 2026 12:42
Currently translated at 80.2% (69 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 9.3% (8 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/ca/
Currently translated at 100.0% (86 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/es_AR/
Currently translated at 94.1% (81 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
Currently translated at 100.0% (85 of 85 strings)

Translation: server-tools-16.0/server-tools-16.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-auto_backup/es/
paramiko 4.0.0 dropped support for DSSKey imported by pysftp. See paramiko/paramiko#2537

```
File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 9, in <module>
    import pysftp
  File "/home/odoo/.cache/pypoetry/virtualenvs/18-0-liVCuCj7-py3.12/lib/python3.12/site-packages/pysftp/__init__.py", line 14, in <module>
    from paramiko import AgentKey, RSAKey, DSSKey
ImportError: cannot import name 'DSSKey' from 'paramiko'
```

The import error was dropped silently, making the error show up as

```
File "/home/odoo/odoo/18.0/server-tools/auto_backup/tests/test_db_backup.py", line 28, in <module>
    class TestConnectionException(pysftp.ConnectionException):
                                  ^^^^^^
NameError: name 'pysftp' is not defined
```
Currently translated at 63.5% (47 of 74 strings)

Translation: server-tools-18.0/server-tools-18.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auto_backup/sl/
Currently translated at 100.0% (74 of 74 strings)

Translation: server-tools-18.0/server-tools-18.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-auto_backup/ru/
@OCA-git-bot OCA-git-bot removed the mod:onchange_helper Module onchange_helper label Jul 17, 2026
@BhaveshHeliconia

Copy link
Copy Markdown
Contributor Author

@simahawk @gurneyalex @thomaspaulb Could you please anyone review and merge this? Thanks!

@thomaspaulb

Copy link
Copy Markdown
Contributor

/ocabot migration auto_backup

/ocabot merge nobump

Please ping the PSC team not the persons thanks

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Jul 17, 2026
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-3592-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 86ec8c9 into OCA:19.0 Jul 17, 2026
6 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 0a561ff. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.