[12.0][FIX] excel_import_export, use sudo() to get param#1636
Conversation
bee009b to
f6c33c7
Compare
f6c33c7 to
1f801da
Compare
|
@pedrobaeza thank you for the review. Fixed. |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
I'm seeing a hole here due to changelog: if you don't put version number and this one gets merged after another PR for the same module, the changelog numbering won't be correct (and that's another reason why I don't like static changelog maintenance having commit history). @sbidoul how do you workaround this problem? |
|
@pedrobaeza about changelogs yes, there is nice tool named towncrier which basically lets you define changelog entries as small files of the form I'm experimenting it on mis builder, and it is somehting we could at some point consider generalizing, with proper OCA tooling such as bot support. |
|
OK, that can be the solution then. |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1636-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1636-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Not sure why it's failing... let's rety again /ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1636-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
No clue what's happening. @kittiu can you rebase this PR to see? |
|
Looks like travis is quite unstable these days. I've restarted the failed travis job. |
|
@pedrobaez is this ok now to quick merge? |
|
Let's merge it manually |
Syncing from upstream OCA/server-tools (13.0)
4 participants
Small fix. Just to ensure that the param path_temp_file is readable.