[10.0][MIG] users_ldap_groups#1144
Merged
Merged
Conversation
hbrunn
force-pushed
the
10.0-users_ldap_groups
branch
2 times, most recently
from
February 5, 2018 19:47
fc02710 to
d37eec8
Compare
hbrunn
force-pushed
the
10.0-users_ldap_groups
branch
from
February 5, 2018 20:52
d37eec8 to
4dd3e43
Compare
sebalix
reviewed
Mar 15, 2018
| search_st=Mock(return_value=[ | ||
| ('cn=hello', {'name': ['hello', 'hello2']}) | ||
| ]), | ||
| )) |
Contributor
There was a problem hiding this comment.
I'm not sure but this patch call will affect the whole Python runtime, no? Would not be better to use the start() method in setUp() and stop() in tearDown()?
Member
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Oups sorry, didn't see it was a decorator on the test class.
Member
Author
There was a problem hiding this comment.
thanks for the review, nothing to apologize!
sebalix
approved these changes
Mar 15, 2018
NL66278
approved these changes
Apr 20, 2018
NL66278
left a comment
NL66278
left a comment
Contributor
There was a problem hiding this comment.
😄 LGTM and tested in practice
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (8.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.