Skip to content

[16.0][FIX] users_ldap_groups JSON RPC vulnerability - #659

Merged
pedrobaeza merged 2 commits into
OCA:16.0from
oh2fih:16.0-jsonrpc-vuln
Jun 6, 2024
Merged

[16.0][FIX] users_ldap_groups JSON RPC vulnerability#659
pedrobaeza merged 2 commits into
OCA:16.0from
oh2fih:16.0-jsonrpc-vuln

Conversation

@oh2fih

@oh2fih oh2fih commented Jun 6, 2024

Copy link
Copy Markdown

Fix #617

res.company.ldap.operator operators should be private methods; public methods allow arbitrary LDAP queries via JSON-API

res.company.ldap.operator operators should be private methods;
public methods allow arbitrary LDAP queries via JSON-API
@pedrobaeza

Copy link
Copy Markdown
Member

Please do a responsible disclosure of any vulnerability. You can't put JSON RPC vulnerability in big in the title to call those who want to exploit it.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 6, 2024
@oh2fih

oh2fih commented Jun 6, 2024

Copy link
Copy Markdown
Author

This information has been out there since Feb 23 as #617 and this fix available since Mar 30 as a part of #596, though...

@pedrobaeza

Copy link
Copy Markdown
Member

Yes, and that was also a non responsible disclosure. It's not your fault though, as there's no mechanism established for this at OCA (cc @vdewulf), as there's for Odoo: https://www.odoo.com/es_ES/security-report

@oh2fih

oh2fih commented Jun 6, 2024

Copy link
Copy Markdown
Author

I agree. Well, https://odoo-community.org/contactus does have security contact information, but the information is a few clicks away from the repository and, therefore, slightly hard to find. Now that I have it, I'll definitely approach the security team first in the future.

@sbidoul

sbidoul commented Jun 6, 2024

Copy link
Copy Markdown
Member

I agree. Well, https://odoo-community.org/contactus does have security contact information, but the information is a few clicks away from the repository and, therefore, slightly hard to find. Now that I have it, I'll definitely approach the security team first in the future.

Good point, @oh2fih. I added a security policy on our GitHub organization. It is now visible on each repo.

@hparfr hparfr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor remark

Comment thread users_ldap_groups/models/res_company_ldap_operator.py
@oh2fih
oh2fih requested a review from hparfr June 6, 2024 14:09
Comment thread users_ldap_groups/models/res_company_ldap_operator.py Outdated
Co-authored-by: Hpar <raph@hpar.fr>
@pedrobaeza

Copy link
Copy Markdown
Member

Let's merge it although the CI is red.

@sbidoul

sbidoul commented Jun 6, 2024

Copy link
Copy Markdown
Member

I opened backport prs for 15, 14, 13.

12 will require manual invervention.

@oh2fih
oh2fih deleted the 16.0-jsonrpc-vuln branch June 6, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vulnerability in users_ldap_groups allows arbitrary LDAP queries via JSON RPC API

6 participants