Skip to content

[18.0][MIG] fastapi_auth_api_key: Migration to 18.0#568

Merged
OCA-git-bot merged 6 commits into
OCA:18.0from
camptocamp:18.0-mig-fastapi_auth_api_key
Oct 24, 2025
Merged

[18.0][MIG] fastapi_auth_api_key: Migration to 18.0#568
OCA-git-bot merged 6 commits into
OCA:18.0from
camptocamp:18.0-mig-fastapi_auth_api_key

Conversation

@yankinmax

Copy link
Copy Markdown
Contributor

@yankinmax yankinmax force-pushed the 18.0-mig-fastapi_auth_api_key branch 4 times, most recently from 9910ca8 to 3304a58 Compare October 2, 2025 11:01

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yankinmax

Please don't only rely on unit tests for this.

Also functionally test it 🙏🏻

Comment thread fastapi_auth_api_key/dependencies.py Outdated
Comment thread fastapi_auth_api_key/dependencies.py Outdated
Comment thread fastapi_auth_api_key/dependencies.py Outdated
Comment thread fastapi_auth_api_key/dependencies.py Outdated
Comment thread fastapi_auth_api_key/dependencies.py Outdated
Comment thread fastapi_auth_api_key/models/fastapi_endpoint.py Outdated
Comment thread fastapi_auth_api_key/tests/test_fastapi_api_key_dependencies.py Outdated
@yankinmax

Copy link
Copy Markdown
Contributor Author

Hello @ivantodorovich, yep my bad. Will rewrite it.

@yankinmax yankinmax force-pushed the 18.0-mig-fastapi_auth_api_key branch 2 times, most recently from 8fa3e0a to 1eb20ff Compare October 2, 2025 12:15

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yankinmax ! 🚀

@vvrossem vvrossem left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can squash the last commit (and add a comment line explaining status.HTTP_422_UNPROCESSABLE_ENTITY is deprecated

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

status.HTTP_422_UNPROCESSABLE_ENTITY is deprecated
@yankinmax yankinmax force-pushed the 18.0-mig-fastapi_auth_api_key branch from 1eb20ff to a5bae2b Compare October 7, 2025 17:08

@etobella etobella left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-568-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit da414c9 into OCA:18.0 Oct 24, 2025
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 1e516ee. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants