Skip to content

[14.0][FIX] base_rest_datamodel: modify validation of responses to allow dump_only fields#191

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
fdegrave:14.0-datamodel-response-validation
Oct 8, 2021
Merged

[14.0][FIX] base_rest_datamodel: modify validation of responses to allow dump_only fields#191
OCA-git-bot merged 1 commit into
OCA:14.0from
fdegrave:14.0-datamodel-response-validation

Conversation

@fdegrave

@fdegrave fdegrave commented Sep 2, 2021 •
edited
Loading

Copy link
Copy Markdown

Forward port of PR #169

@OCA-git-bot

OCA-git-bot commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

Hi @fdegrave! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

@fdegrave
fdegrave force-pushed the 14.0-datamodel-response-validation branch from 8b86913 to b21e255 Compare September 2, 2021 13:54
@lmignon

lmignon commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-191-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 8, 2021
@OCA-git-bot
Merge PR #191 into 14.0
cfca082 
Signed-off-by lmignon
@lmignon

lmignon commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

#169 is being meged.... Let's do the same for 14.0

@OCA-git-bot

OCA-git-bot commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-191-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit b8c17ad into OCA:14.0 Oct 8, 2021
@OCA-git-bot

OCA-git-bot commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at a4715aa. Thanks a lot for contributing to OCA. ❤️

@fdegrave
fdegrave deleted the 14.0-datamodel-response-validation branch October 28, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon approved these changes

Assignees

No one assigned

Labels

14.0 merged 🎉 needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fdegrave @OCA-git-bot @lmignon