[17.0][FIX] bi_sql_editor: bi_sql_editor.menu_bi_sql_editor not found - #1036
Merged
OCA-git-bot merged 1 commit intoJun 20, 2025
Merged
Conversation
Contributor
|
Hi @legalsylvain, |
vvrossem
changed the title
bi_sql_editor.menu_bi_sql_editor not foundbi_sql_editor.menu_bi_sql_editor not found
yankinmax
approved these changes
Jun 20, 2025
yankinmax
left a comment
yankinmax
left a comment
Contributor
There was a problem hiding this comment.
Good catch indeed, thanks
legalsylvain
requested changes
Jun 20, 2025
legalsylvain
left a comment
legalsylvain
left a comment
Contributor
There was a problem hiding this comment.
a remark inline. Otherwise, lgtm.
thanks !
vvrossem
force-pushed
the
17.0-fix-bi_sql_editor-external-id-not-found
branch
from
June 20, 2025 07:51
f8d2d2e to
ea93212
Compare
legalsylvain
approved these changes
Jun 20, 2025
legalsylvain
left a comment
legalsylvain
left a comment
Contributor
There was a problem hiding this comment.
/ocabot merge patch
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Hi @vvrossem. could you port this patch upstream ? thanks |
Contributor
|
Congratulations, your PR was merged at cb4f3ee. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.