[FIX] maintenance_equipment_sequence: convert create to api.model_create_multi#564
Open
miquelrosell99 wants to merge 2 commits into
Conversation
Contributor
|
Hi @AdriaGForgeFlow, |
OCA-git-bot
added
series:17.0
mod:maintenance_equipment_sequence
dalonsod
suggested changes
May 20, 2026
dalonsod
left a comment
dalonsod
left a comment
Contributor
There was a problem hiding this comment.
See possible performance improvement comment
miquelrosell99
force-pushed
the
17.0-fix-maintenance-equipment-sequence-model-create-multi
branch
from
4135a30 to
e786ec7
Compare
…ate_multi Converts MaintenanceEquipmentCategory.create() and MaintenanceEquipment.create() to batch-compatible api.model_create_multi for Odoo 17 best practice. Browse calls are batched outside loops to avoid repeated database queries when creating records in bulk.
miquelrosell99
force-pushed
the
17.0-fix-maintenance-equipment-sequence-model-create-multi
branch
from
e786ec7 to
09eedbd
Compare
Author
|
Hi @dalonsod, thanks for the review. The batching change you suggested is already in place in the current branch:
I believe this addresses the performance concern. Could you please re-review when you have a moment? |
cgarcia-solvos
approved these changes
Jun 30, 2026
cgarcia-solvos
left a comment
cgarcia-solvos
left a comment
Contributor
There was a problem hiding this comment.
Code review. LGTM
Co-authored-by: Carlos García <carlos.garcia@solvos.es>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts MaintenanceEquipmentCategory.create() and MaintenanceEquipment.create() to batch-compatible api.model_create_multi for Odoo 17 best practice.