[17.0][FIX] don't set install_filename when loading views from openupgrade_scripts#5754
Merged
Conversation
Contributor
|
Hi @StefanRijnhart, @legalsylvain, @hbrunn, |
OCA-git-bot
added
mod:openupgrade_scripts
hbrunn
requested changes
Jun 29, 2026
| path_info = get_resource_from_path(self._context["install_filename"]) | ||
| if path_info[0] == "openupgrade_scripts": | ||
| self = self.with_context( | ||
| **{k: v for k, v in self._context.items() if k != "install_filename"} |
Member
There was a problem hiding this comment.
this makes this monkey patch basically a no-op. remove this commit, then with what you did just now you should be fine
Author
There was a problem hiding this comment.
Thank you, I didn't understand that exploding it like suggested by the Pylint warning would change the behavior when removing elements from the context. I reverted the change and disabled the warning.
Author
|
Changes done. I can squash before or after approval, as you prefer @hbrunn . |
Member
|
please do the squashing |
hbrunn
approved these changes
Jun 30, 2026
pedrobaeza
approved these changes
Jun 30, 2026
Member
|
This contains a bug fixed in #5764 |
Author
|
I didn't see the fix that was already in the 18.0 and 19.0 branches, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport changes from #5445 on 18.0 to OpenUpgrade 17.0 through a cherry-pick of the commit from 18.0.
As commented in #5437, I got the issue when migrating the portal module from 16.0 to 17.0.
Cherry-picking the commit on local fixed the issue for me.