[18.0][FIX]openupgrade_framework: Fix Nonetype Error when install_filename …#5448
Merged
Merged
Conversation
…path does not exist
Contributor
|
Hi @StefanRijnhart, @hbrunn, @legalsylvain, |
javierjcf
changed the title
hbrunn
approved these changes
Nov 10, 2025
pedrobaeza
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…path does not exist
In my doodba insrtance, migrating this week to v18 fail since this commit :527770f
Although the install_filename key exists in self._context, the function get_resource_from_path returns None for my environment. Consequently, attempting to access path_info[0] raises an error (e.g., TypeError: 'NoneType' object is not subscriptable), which breaks the migration process.
A necessary fix would be to add a check for the existence of path_info before attempting to access its elements: