[17.0][OU-FIX] sale_stock: Missing migration script#4749
Conversation
|
/ocabot migration sale_stock |
pedrobaeza
force-pushed
the
17.0-ou_fix-sale_stock
branch
2 times, most recently
from
28e181a to
ccbbf04
Compare
pedrobaeza
force-pushed
the
17.0-ou_fix-sale_stock
branch
from
ccbbf04 to
7acdc31
Compare
|
Shouldn't you modify the analysis work file? |
|
No, as this field is not logged in this module. It's just the overridden computed. |
| # Fill delivery_date and incoterm_location according | ||
| # https://github.com/odoo/odoo/blob/00818b7bfaf22635b0c40b3b9c7e37e0c9789da1/ | ||
| # addons/sale_stock/models/account_move.py#L116-L134 | ||
| openupgrade.logged_query( |
There was a problem hiding this comment.
I think we should apply some WHERE conditions... I mean, what happens if you have a LOT of sale order lines performance-wise?
There was a problem hiding this comment.
This SQL is already optimized, so it won't suffer in case of a big number of lines. You can try in a DB with lots of them (or use the populate tool for it).
There was a problem hiding this comment.
The JOIN conditions are the "WHEREs" 😉
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 9d90a5c. Thanks a lot for contributing to OCA. ❤️ |
3 participants
Honor
OpenUpgrade/openupgrade_scripts/scripts/account/17.0.1.2/upgrade_analysis_work.txt
Line 138 in 44ca598
@Tecnativa TT49892